Merged
Conversation
e-n-0
approved these changes
Nov 12, 2025
|
lucaspimentel
approved these changes
Nov 12, 2025
| // // Workaround for https://github.com/dotnet/runtime/issues/95653 | ||
| // EnvironmentVariables = new[] { ("DD_CLR_ENABLE_INLINING", "0") }, | ||
| //}, | ||
| ExplorationTestName.automapper => new ExplorationTestDescription() |
Member
There was a problem hiding this comment.
The PR description says the AutoMapper exploration tests are still broken. Do we actually want to enable them?
Member
Author
There was a problem hiding this comment.
I have a follow up commit to remove them again, just letting this run finish first to see if there's anything else to fix at the same time 🙂
gleocadie
approved these changes
Nov 12, 2025
| new StackFrame("|lm:Samples.ExceptionGenerator |ns:Samples.ExceptionGenerator |ct:ParallelExceptionsScenario |cg: |fn:ThrowExceptions |fg: |sg:(object state)")); | ||
| } | ||
| } | ||
| else if (framework =="net10.0") |
bouwkast
approved these changes
Nov 12, 2025
|
|
||
| // .NET Core 3.1+, but is it _too_ high? | ||
| if(runtimeInformation.major_version <= 9) | ||
| if(runtimeInformation.major_version <= 10) |
Collaborator
There was a problem hiding this comment.
Should we make note of this that SSI will now automatically support .NET 10?
Member
Author
There was a problem hiding this comment.
I think putting in the release notes is good enough, but we can ping internal teams too. Were you thinking about anything else?
link04
approved these changes
Nov 12, 2025
tonyredondo
approved these changes
Nov 12, 2025
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7804) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7804) - mean (76ms) : 71, 80
master - mean (75ms) : 71, 79
section Bailout
This PR (7804) - mean (80ms) : 75, 84
master - mean (80ms) : 76, 85
section CallTarget+Inlining+NGEN
This PR (7804) - mean (1,139ms) : 1043, 1235
master - mean (1,134ms) : 1053, 1215
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7804) - mean (118ms) : 111, 125
master - mean (119ms) : 111, 128
section Bailout
This PR (7804) - mean (119ms) : 113, 126
master - mean (120ms) : 112, 128
section CallTarget+Inlining+NGEN
This PR (7804) - mean (814ms) : 770, 858
master - mean (819ms) : 764, 874
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7804) - mean (105ms) : 98, 112
master - mean (105ms) : 97, 114
section Bailout
This PR (7804) - mean (106ms) : 99, 113
master - mean (106ms) : 101, 112
section CallTarget+Inlining+NGEN
This PR (7804) - mean (756ms) : 709, 803
master - mean (769ms) : 706, 832
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7804) - mean (103ms) : 96, 110
master - mean (104ms) : 97, 111
section Bailout
This PR (7804) - mean (105ms) : 99, 110
master - mean (105ms) : 98, 113
section CallTarget+Inlining+NGEN
This PR (7804) - mean (713ms) : 677, 748
master - mean (741ms) : 706, 775
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7804) - mean (193ms) : 189, 197
master - mean (195ms) : 190, 199
section Bailout
This PR (7804) - mean (198ms) : 192, 203
master - mean (198ms) : 193, 204
section CallTarget+Inlining+NGEN
This PR (7804) - mean (1,176ms) : 1110, 1243
master - mean (1,186ms) : 1110, 1262
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7804) - mean (278ms) : 273, 283
master - mean (281ms) : 272, 291
section Bailout
This PR (7804) - mean (278ms) : 273, 283
master - mean (279ms) : 272, 285
section CallTarget+Inlining+NGEN
This PR (7804) - mean (950ms) : 905, 995
master - mean (953ms) : 906, 1001
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7804) - mean (270ms) : 266, 274
master - mean (270ms) : 266, 275
section Bailout
This PR (7804) - mean (270ms) : 266, 275
master - mean (271ms) : 265, 278
section CallTarget+Inlining+NGEN
This PR (7804) - mean (922ms) : 871, 972
master - mean (939ms) : 882, 997
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7804) - mean (269ms) : 265, 274
master - mean (270ms) : 264, 276
section Bailout
This PR (7804) - mean (269ms) : 266, 273
master - mean (272ms) : 266, 277
section CallTarget+Inlining+NGEN
This PR (7804) - mean (851ms) : 831, 870
master - mean (863ms) : 838, 887
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
e-n-0
pushed a commit
that referenced
this pull request
Dec 2, 2025
## Summary of changes Update CI to use GA version of .NET SDK ## Reason for change .NET 10 was released yesterday, and we want to use it! ## Implementation details - Follow our docs to update to .NET 10 - Update the VMs - Fix profiler integration test (broken by a change in the stack trace in .NET 10 on x64) - Add some missing/additional smoke tests - Had to remove some again because realised the OSs haven't _actually_ updated their repos to .NET 10 GA - [x] Reinstate [the broken automapper exploration tests](271ad61) - Nope, they're still broken 🤷♂️ ## Test coverage Will run the full installer test suite to make sure everything looks ok We have a _weird_ failure with xUnit, that's _only_ happening on .NET Core 3.1, Windows, x64, where `Environment.OSVersion.VersionString` is apparently returning the wrong string. Discussed with @tonyredondo and we have no idea what's going on 😅 Feels like something broken in the VM, but seeing it happen somewhat consistently, so we might just skip it and come back to it... ``` Error Message: 12:24:57 [DBG] Expected string to be "Microsoft Windows NT 10.0.20348.0" with a length of 33, but "Microsoft Windows NT 6.2.9200.0" has a length of 31, differs near "6.2" (index 21). 12:24:57 [DBG] Stack Trace: 12:24:57 [DBG] at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message) 12:24:57 [DBG] at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message) 12:24:57 [DBG] at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message) 12:24:57 [DBG] at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc) 12:24:57 [DBG] at FluentAssertions.Primitives.StringEqualityValidator.ValidateAgainstLengthDifferences() 12:24:57 [DBG] at FluentAssertions.Primitives.StringValidator.Validate() 12:24:57 [DBG] at FluentAssertions.Primitives.StringAssertions`1.Be(String expected, String because, Object[] becauseArgs) 12:24:57 [DBG] at Datadog.Trace.ClrProfiler.IntegrationTests.CI.TestingFrameworkTest.AssertTargetSpanEqual(MockSpan targetSpan, String key, String value) in D:\a\_work\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\CI\TestingFrameworkTest.cs:line 110 12:24:57 [DBG] at Datadog.Trace.ClrProfiler.IntegrationTests.CI.TestingFrameworkTest.CheckRuntimeValues(MockSpan targetSpan) in D:\a\_work\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\CI\TestingFrameworkTest.cs:line 133 12:24:57 [DBG] at Datadog.Trace.ClrProfiler.IntegrationTests.CI.XUnitTests.SubmitTraces(String packageVersion) in D:\a\_work\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\CI\XUnitTests.cs:line 96 12:24:57 [DBG] at Datadog.Trace.ClrProfiler.IntegrationTests.CI.PipesXUnitTests.SubmitTraces(String packageVersion) in D:\a\_work\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\CI\PipesXUnitTests.cs:line 31 ``` ## Other details https://datadoghq.atlassian.net/browse/LANGPLAT-840 Related PRs: - DataDog/images#8001 - DataDog/benchmarking-platform#210 - DataDog/benchmarking-platform#211 - DataDog/serverless-tools#83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Update CI to use GA version of .NET SDK
Reason for change
.NET 10 was released yesterday, and we want to use it!
Implementation details
Test coverage
Will run the full installer test suite to make sure everything looks ok
We have a weird failure with xUnit, that's only happening on .NET Core 3.1, Windows, x64, where
Environment.OSVersion.VersionStringis apparently returning the wrong string. Discussed with @tonyredondo and we have no idea what's going on 😅 Feels like something broken in the VM, but seeing it happen somewhat consistently, so we might just skip it and come back to it...Other details
https://datadoghq.atlassian.net/browse/LANGPLAT-840
Related PRs: