Skip to content

Remove CodeQL workflow#7701

Merged
NachoEchevarria merged 3 commits intomasterfrom
nacho/RemoveCodeQlAnalysys
Oct 23, 2025
Merged

Remove CodeQL workflow#7701
NachoEchevarria merged 3 commits intomasterfrom
nacho/RemoveCodeQlAnalysys

Conversation

@NachoEchevarria
Copy link
Collaborator

@NachoEchevarria NachoEchevarria commented Oct 23, 2025 •
edited
Loading

Summary of changes

The job CodeQL is failing in .Net 10 RC2 branches, probably related to this.

We will temporarly disable it until .Net 10 GA.

Reason for change

Implementation details

Test coverage

Other details

@NachoEchevarria NachoEchevarria changed the title Remove codeql workflow Remove codeQl workflow Oct 23, 2025
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 23, 2025
@NachoEchevarria NachoEchevarria changed the title Remove codeQl workflow Remove CodeQL workflow Oct 23, 2025
@NachoEchevarria NachoEchevarria marked this pull request as ready for review October 23, 2025 15:23
@NachoEchevarria NachoEchevarria requested a review from a team as a code owner October 23, 2025 15:23
andrewlock
andrewlock approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we reinstate it once GA is released and it's un-broken by github/codeql-action#3207!

@pr-commenter
Copy link

pr-commenter bot commented Oct 23, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7701 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.879
  • 1 benchmarks are slower, with geometric mean 2.063
  • 1 benchmarks have fewer allocations
  • 6 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.8μs 60.3ns 376ns 0 0 0 5.51 KB
master StartStopWithChild netcoreapp3.1 14.4μs 74.8ns 359ns 0 0 0 5.69 KB
master StartStopWithChild net472 22μs 114ns 536ns 0.973 0.324 0.108 6.05 KB
#7701 StartStopWithChild net6.0 10.6μs 58.4ns 374ns 0 0 0 5.49 KB
#7701 StartStopWithChild netcoreapp3.1 13.9μs 70.3ns 315ns 0 0 0 5.7 KB
#7701 StartStopWithChild net472 21.9μs 121ns 705ns 0.882 0.22 0 6.08 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 952μs 391ns 1.41μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 142ns 550ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 413ns 1.6μs 0 0 0 3.31 KB
#7701 WriteAndFlushEnrichedTraces net6.0 923μs 333ns 1.25μs 0 0 0 2.71 KB
#7701 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 66.8ns 241ns 0 0 0 2.7 KB
#7701 WriteAndFlushEnrichedTraces net472 1.19ms 326ns 1.13μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleSimpleBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleSimpleBody net472 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleMoreComplexBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleMoreComplexBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleMoreComplexBody net472 N/A N/A N/A NaN NaN NaN 0 b
master ObjectExtractorSimpleBody net6.0 340ns 0.246ns 0.919ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 396ns 2.18ns 11.9ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 308ns 0.17ns 0.658ns 0.0434 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.23μs 33.3ns 173ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.86μs 38.1ns 157ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.69μs 3.18ns 12.3ns 0.57 0 0 3.8 KB
#7701 AllCycleSimpleBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7701 AllCycleSimpleBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7701 AllCycleSimpleBody net472 N/A N/A N/A NaN NaN NaN 0 b
#7701 AllCycleMoreComplexBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7701 AllCycleMoreComplexBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7701 AllCycleMoreComplexBody net472 N/A N/A N/A NaN NaN NaN 0 b
#7701 ObjectExtractorSimpleBody net6.0 321ns 1.79ns 11ns 0 0 0 280 B
#7701 ObjectExtractorSimpleBody netcoreapp3.1 394ns 2.18ns 12.5ns 0 0 0 272 B
#7701 ObjectExtractorSimpleBody net472 295ns 0.0429ns 0.166ns 0.0432 0 0 281 B
#7701 ObjectExtractorMoreComplexBody net6.0 6.37μs 1.91ns 7.4ns 0 0 0 3.78 KB
#7701 ObjectExtractorMoreComplexBody netcoreapp3.1 7.75μs 36.9ns 156ns 0 0 0 3.69 KB
#7701 ObjectExtractorMoreComplexBody net472 6.66μs 0.708ns 2.55ns 0.599 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.9μs 106ns 409ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.8μs 295ns 1.14μs 0 0 0 32.4 KB
master EncodeArgs net472 109μs 22.8ns 88.4ns 4.89 0 0 32.51 KB
master EncodeLegacyArgs net6.0 144μs 13.8ns 53.4ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 202μs 340ns 1.27μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 264μs 45.6ns 176ns 0 0 0 2.16 KB
#7701 EncodeArgs net6.0 77.4μs 103ns 385ns 0 0 0 32.4 KB
#7701 EncodeArgs netcoreapp3.1 96.8μs 121ns 452ns 0 0 0 32.4 KB
#7701 EncodeArgs net472 111μs 15.3ns 59.1ns 4.99 0 0 32.51 KB
#7701 EncodeLegacyArgs net6.0 145μs 8.62ns 31.1ns 0 0 0 2.15 KB
#7701 EncodeLegacyArgs netcoreapp3.1 200μs 230ns 891ns 0 0 0 2.14 KB
#7701 EncodeLegacyArgs net472 263μs 16.5ns 63.9ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7701

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 2.063 414,421.67 855,040.26

More allocations ⚠️ in #7701

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 4.48 KB 4.77 KB 288 B 6.43%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 393μs 217ns 840ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 415μs 96.2ns 347ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 427μs 27.3ns 98.4ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 283μs 35.1ns 131ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 298μs 225ns 870ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 310μs 30ns 116ns 0 0 0 2.29 KB
#7701 RunWafRealisticBenchmark net6.0 394μs 51ns 191ns 0 0 0 4.55 KB
#7701 RunWafRealisticBenchmark netcoreapp3.1 846μs 4.32μs 21.2μs 0 0 0 4.77 KB
#7701 RunWafRealisticBenchmark net472 427μs 41.5ns 150ns 0 0 0 4.66 KB
#7701 RunWafRealisticBenchmarkWithAttack net6.0 288μs 40.6ns 157ns 0 0 0 2.24 KB
#7701 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 298μs 56.8ns 197ns 0 0 0 2.22 KB
#7701 RunWafRealisticBenchmarkWithAttack net472 310μs 32.9ns 123ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 60.5μs 55.6ns 215ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.7μs 150ns 563ns 0 0 0 17.42 KB
master SendRequest net472 0.00267ns 0.00131ns 0.00506ns 0 0 0 0 b
#7701 SendRequest net6.0 61.5μs 82.6ns 286ns 0 0 0 14.52 KB
#7701 SendRequest netcoreapp3.1 71.3μs 127ns 476ns 0 0 0 17.42 KB
#7701 SendRequest net472 0.000411ns 0.000287ns 0.00108ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7701

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 1 B 3 B 2 B 200.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 6 B 10 B 4 B 66.67%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.89ms 919ns 3.44μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.12ms 7.88μs 30.5μs 0 0 0 640 KB
master OriginalCharSlice net472 2.55ms 190ns 713ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.38ms 243ns 940ns 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.66ms 343ns 1.28μs 0 0 0 1 B
master OptimizedCharSlice net472 1.93ms 157ns 607ns 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 898μs 98.8ns 383ns 0 0 0 1 B
master OptimizedCharSliceWithPool netcoreapp3.1 811μs 166ns 621ns 0 0 0 6 B
master OptimizedCharSliceWithPool net472 1.15ms 114ns 440ns 0 0 0 0 b
#7701 OriginalCharSlice net6.0 1.9ms 4.28μs 16.6μs 0 0 0 640 KB
#7701 OriginalCharSlice netcoreapp3.1 2.16ms 10.2μs 57.9μs 0 0 0 640 KB
#7701 OriginalCharSlice net472 2.61ms 87.4ns 315ns 100 0 0 641.95 KB
#7701 OptimizedCharSlice net6.0 1.37ms 223ns 833ns 0 0 0 4 B
#7701 OptimizedCharSlice netcoreapp3.1 1.69ms 374ns 1.45μs 0 0 0 1 B
#7701 OptimizedCharSlice net472 1.91ms 201ns 725ns 0 0 0 0 b
#7701 OptimizedCharSliceWithPool net6.0 888μs 56.1ns 217ns 0 0 0 3 B
#7701 OptimizedCharSliceWithPool netcoreapp3.1 899μs 74.6ns 289ns 0 0 0 10 B
#7701 OptimizedCharSliceWithPool net472 1.14ms 164ns 633ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #7701

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.123 740,896.88 659,679.17

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 742μs 2.01μs 7.79μs 0 0 0 41.64 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 726μs 1.04μs 4.04μs 0 0 0 42.24 KB
master WriteAndFlushEnrichedTraces net472 904μs 4.57μs 21μs 4.46 0 0 55.96 KB
#7701 WriteAndFlushEnrichedTraces net6.0 660μs 3.27μs 17.9μs 0 0 0 41.57 KB
#7701 WriteAndFlushEnrichedTraces netcoreapp3.1 711μs 3.95μs 24.4μs 0 0 0 42.08 KB
#7701 WriteAndFlushEnrichedTraces net472 883μs 2.28μs 8.81μs 8.33 0 0 55.91 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.95μs 0.533ns 1.99ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.6μs 1.89ns 6.81ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.91μs 3.49ns 13.5ns 0.143 0.0143 0 987 B
#7701 ExecuteNonQuery net6.0 1.95μs 6.15ns 23.8ns 0 0 0 1.02 KB
#7701 ExecuteNonQuery netcoreapp3.1 2.62μs 3.92ns 15.2ns 0 0 0 1.02 KB
#7701 ExecuteNonQuery net472 2.84μs 3.59ns 13.9ns 0.157 0.0142 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.68μs 8.33ns 36.3ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.2μs 5.6ns 21.7ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.5μs 4.22ns 16.3ns 0.158 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.83μs 5.3ns 19.1ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.36μs 10.9ns 42.2ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.6μs 2.09ns 8.08ns 0.163 0 0 1.1 KB
#7701 CallElasticsearch net6.0 1.73μs 6.55ns 25.4ns 0 0 0 1.03 KB
#7701 CallElasticsearch netcoreapp3.1 2.2μs 10.9ns 45ns 0 0 0 1.03 KB
#7701 CallElasticsearch net472 3.5μs 0.913ns 3.42ns 0.157 0 0 1.04 KB
#7701 CallElasticsearchAsync net6.0 1.89μs 10ns 50.2ns 0 0 0 1.01 KB
#7701 CallElasticsearchAsync netcoreapp3.1 2.38μs 10.5ns 40.8ns 0 0 0 1.08 KB
#7701 CallElasticsearchAsync net472 3.62μs 3.59ns 13.9ns 0.162 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.88μs 8.97ns 35.9ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.44μs 5.09ns 19.7ns 0 0 0 952 B
master ExecuteAsync net472 2.63μs 2.23ns 8.63ns 0.143 0 0 915 B
#7701 ExecuteAsync net6.0 1.85μs 8.65ns 35.7ns 0 0 0 952 B
#7701 ExecuteAsync netcoreapp3.1 2.44μs 7.73ns 28.9ns 0 0 0 952 B
#7701 ExecuteAsync net472 2.66μs 5.68ns 22ns 0.133 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.86μs 6.71ns 26ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.72μs 26.2ns 102ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 7.61ns 28.5ns 0.487 0 0 3.18 KB
#7701 SendAsync net6.0 6.83μs 9.91ns 38.4ns 0 0 0 2.36 KB
#7701 SendAsync netcoreapp3.1 8.48μs 12.5ns 48.5ns 0 0 0 2.9 KB
#7701 SendAsync net472 12.6μs 9.85ns 38.2ns 0.443 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #7701

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 3.144 1,546,250.00 491,800.00

More allocations ⚠️ in #7701

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 250.46 KB 274.09 KB 23.63 KB 9.44%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.92 KB 45.13 KB 2.21 KB 5.14%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.78 KB 44.59 KB 816 B 1.86%

Fewer allocations 🎉 in #7701

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 335.15 KB 255.29 KB -79.86 KB -23.83%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 41.7μs 209ns 886ns 0 0 0 43.78 KB
master StringConcatBenchmark netcoreapp3.1 47.8μs 164ns 658ns 0 0 0 42.92 KB
master StringConcatBenchmark net472 57μs 261ns 1.04μs 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 441μs 645ns 2.23μs 0 0 0 250.46 KB
master StringConcatAspectBenchmark netcoreapp3.1 1.55ms 2.22μs 8.32μs 0 0 0 335.15 KB
master StringConcatAspectBenchmark net472 411μs 2.06μs 8.72μs 0 0 0 286.02 KB
#7701 StringConcatBenchmark net6.0 45.2μs 315ns 2.99μs 0 0 0 44.59 KB
#7701 StringConcatBenchmark netcoreapp3.1 49.7μs 288ns 2.17μs 0 0 0 45.13 KB
#7701 StringConcatBenchmark net472 57.2μs 125ns 450ns 0 0 0 57.34 KB
#7701 StringConcatAspectBenchmark net6.0 464μs 1.74μs 6.03μs 0 0 0 274.09 KB
#7701 StringConcatAspectBenchmark netcoreapp3.1 492μs 848ns 3.98μs 0 0 0 255.29 KB
#7701 StringConcatAspectBenchmark net472 406μs 1.83μs 8.18μs 0 0 0 285.14 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 4.76ns 17.8ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.54μs 18.5ns 90.6ns 0 0 0 1.71 KB
master EnrichedLog net472 3.84μs 1.57ns 5.87ns 0.25 0 0 1.64 KB
#7701 EnrichedLog net6.0 2.58μs 13.7ns 72.6ns 0 0 0 1.7 KB
#7701 EnrichedLog netcoreapp3.1 3.67μs 16.7ns 64.7ns 0 0 0 1.7 KB
#7701 EnrichedLog net472 3.79μs 2.29ns 8.57ns 0.247 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 89.6ns 323ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 128μs 25.6ns 92.4ns 0 0 0 4.31 KB
master EnrichedLog net472 168μs 42.9ns 166ns 0 0 0 4.52 KB
#7701 EnrichedLog net6.0 124μs 111ns 385ns 0 0 0 4.31 KB
#7701 EnrichedLog netcoreapp3.1 129μs 72.5ns 281ns 0 0 0 4.31 KB
#7701 EnrichedLog net472 168μs 61ns 236ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.97μs 13.2ns 51ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.8μs 12.1ns 46.8ns 0 0 0 2.26 KB
master EnrichedLog net472 7.7μs 8.85ns 34.3ns 0.307 0 0 2.08 KB
#7701 EnrichedLog net6.0 5.06μs 4.27ns 16ns 0 0 0 2.26 KB
#7701 EnrichedLog netcoreapp3.1 6.9μs 9.89ns 38.3ns 0 0 0 2.26 KB
#7701 EnrichedLog net472 7.62μs 6.02ns 23.3ns 0.304 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2μs 0.971ns 3.5ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.69μs 1.35ns 5.25ns 0 0 0 1.2 KB
master SendReceive net472 3.18μs 2.59ns 10ns 0.19 0 0 1.2 KB
#7701 SendReceive net6.0 2μs 9.43ns 36.5ns 0 0 0 1.2 KB
#7701 SendReceive netcoreapp3.1 2.71μs 4.96ns 19.2ns 0 0 0 1.2 KB
#7701 SendReceive net472 3.01μs 3.3ns 12.8ns 0.18 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.4μs 14.9ns 57.5ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.73μs 19.8ns 76.5ns 0 0 0 1.63 KB
master EnrichedLog net472 6.71μs 5.97ns 22.3ns 0.299 0 0 2.03 KB
#7701 EnrichedLog net6.0 4.28μs 7.69ns 29.8ns 0 0 0 1.58 KB
#7701 EnrichedLog netcoreapp3.1 5.57μs 17.2ns 66.7ns 0 0 0 1.63 KB
#7701 EnrichedLog net472 6.66μs 7.4ns 28.6ns 0.297 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 790ns 0.365ns 1.41ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 981ns 5.14ns 26.2ns 0 0 0 576 B
master StartFinishSpan net472 920ns 0.55ns 2.06ns 0.0882 0 0 578 B
master StartFinishScope net6.0 912ns 3.36ns 12.6ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.17μs 6.25ns 31.3ns 0 0 0 696 B
master StartFinishScope net472 1.16μs 1.07ns 4.14ns 0.105 0 0 658 B
#7701 StartFinishSpan net6.0 769ns 0.155ns 0.58ns 0 0 0 576 B
#7701 StartFinishSpan netcoreapp3.1 1.02μs 2.07ns 8.02ns 0 0 0 576 B
#7701 StartFinishSpan net472 912ns 0.317ns 1.23ns 0.0916 0 0 578 B
#7701 StartFinishScope net6.0 909ns 1.98ns 7.68ns 0 0 0 696 B
#7701 StartFinishScope netcoreapp3.1 1.19μs 5.52ns 22.1ns 0 0 0 696 B
#7701 StartFinishScope net472 1.16μs 1.69ns 6.54ns 0.1 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.06μs 5.42ns 26.5ns 0 0 0 697 B
master RunOnMethodBegin netcoreapp3.1 1.41μs 7.25ns 34.8ns 0 0 0 696 B
master RunOnMethodBegin net472 1.43μs 0.56ns 2.1ns 0.1 0 0 658 B
#7701 RunOnMethodBegin net6.0 1.09μs 5.34ns 21.4ns 0 0 0 696 B
#7701 RunOnMethodBegin netcoreapp3.1 1.44μs 7.37ns 34.6ns 0 0 0 696 B
#7701 RunOnMethodBegin net472 1.45μs 0.808ns 2.91ns 0.102 0 0 658 B

@NachoEchevarria NachoEchevarria merged commit bc90bc6 into master Oct 23, 2025
94 of 98 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/RemoveCodeQlAnalysys branch October 23, 2025 16:23
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.30.0

Development

Successfully merging this pull request may close these issues.

3 participants

@NachoEchevarria @bouwkast @andrewlock