Skip to content

Update .gitignore to ignore local Claude Code settings#7691

Merged
lucaspimentel merged 2 commits intomasterfrom
lpimentel/ignore-local-claude-settings
Oct 21, 2025
Merged

Update .gitignore to ignore local Claude Code settings#7691
lucaspimentel merged 2 commits intomasterfrom
lpimentel/ignore-local-claude-settings

Conversation

@lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Oct 21, 2025 •
edited
Loading

Summary of changes

Ignore .claude/settings.local.json in Git. Also exclude .gitignore changes from triggering the CI pipeline.

Reason for change

Personal Claude Code settings shouldn't be committed.

Implementation details

Added one line each to .gitignore and ultimate-pipeline.yml.

Test coverage

N/A

Other details

N/A

@lucaspimentel
Update .gitignore to ignore Claude settings
cc29347 
Add .claude/settings.local.json to .gitignore
@lucaspimentel lucaspimentel requested a review from a team as a code owner October 21, 2025 20:16
@lucaspimentel lucaspimentel enabled auto-merge (squash) October 21, 2025 20:24
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 21, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7691) - mean (77ms)  : 70, 84
     .   : milestone, 77,
    master - mean (74ms)  : 72, 76
     .   : milestone, 74,

    section Baseline
    This PR (7691) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (7691) - mean (1,067ms)  : 1004, 1130
     .   : milestone, 1067,
    master - mean (1,059ms)  : 1002, 1116
     .   : milestone, 1059,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7691) - mean (109ms)  : 107, 112
     .   : milestone, 109,
    master - mean (110ms)  : 107, 112
     .   : milestone, 110,

    section Baseline
    This PR (7691) - mean (109ms)  : 105, 113
     .   : milestone, 109,
    master - mean (109ms)  : 107, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (7691) - mean (761ms)  : 727, 795
     .   : milestone, 761,
    master - mean (755ms)  : 734, 776
     .   : milestone, 755,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7691) - mean (98ms)  : 95, 100
     .   : milestone, 98,
    master - mean (98ms)  : 96, 99
     .   : milestone, 98,

    section Baseline
    This PR (7691) - mean (96ms)  : 94, 99
     .   : milestone, 96,
    master - mean (97ms)  : 95, 100
     .   : milestone, 97,

    section CallTarget+Inlining+NGEN
    This PR (7691) - mean (721ms)  : 681, 761
     .   : milestone, 721,
    master - mean (713ms)  : 693, 733
     .   : milestone, 713,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7691) - mean (97ms)  : 94, 100
     .   : milestone, 97,
    master - mean (96ms)  : 94, 98
     .   : milestone, 96,

    section Baseline
    This PR (7691) - mean (95ms)  : 93, 98
     .   : milestone, 95,
    master - mean (95ms)  : 93, 98
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (7691) - mean (668ms)  : 654, 681
     .   : milestone, 668,
    master - mean (678ms)  : 664, 692
     .   : milestone, 678,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7691) - mean (196ms)  : 193, 199
     .   : milestone, 196,
    master - mean (197ms)  : 194, 199
     .   : milestone, 197,

    section Baseline
    This PR (7691) - mean (193ms)  : 189, 198
     .   : milestone, 193,
    master - mean (194ms)  : 189, 198
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (7691) - mean (1,181ms)  : 1101, 1262
     .   : milestone, 1181,
    master - mean (1,176ms)  : 1101, 1250
     .   : milestone, 1176,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7691) - mean (278ms)  : 272, 284
     .   : milestone, 278,
    master - mean (277ms)  : 273, 282
     .   : milestone, 277,

    section Baseline
    This PR (7691) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (276ms)  : 272, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (7691) - mean (941ms)  : 901, 981
     .   : milestone, 941,
    master - mean (946ms)  : 906, 986
     .   : milestone, 946,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7691) - mean (269ms)  : 266, 273
     .   : milestone, 269,
    master - mean (276ms)  : 269, 284
     .   : milestone, 276,

    section Baseline
    This PR (7691) - mean (270ms)  : 266, 273
     .   : milestone, 270,
    master - mean (275ms)  : 268, 282
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (7691) - mean (928ms)  : 875, 982
     .   : milestone, 928,
    master - mean (934ms)  : 885, 984
     .   : milestone, 934,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7691) - mean (270ms)  : 265, 275
     .   : milestone, 270,
    master - mean (270ms)  : 266, 274
     .   : milestone, 270,

    section Baseline
    This PR (7691) - mean (269ms)  : 265, 273
     .   : milestone, 269,
    master - mean (269ms)  : 264, 275
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7691) - mean (856ms)  : 833, 880
     .   : milestone, 856,
    master - mean (860ms)  : 839, 882
     .   : milestone, 860,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Oct 21, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7691 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.132
  • 5 benchmarks have fewer allocations
  • 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7691

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.7 KB 5.74 KB 41 B 0.72%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.02 KB 6.05 KB 32 B 0.53%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.1μs 59.2ns 313ns 0 0 0 5.52 KB
master StartStopWithChild netcoreapp3.1 13.6μs 51ns 197ns 0 0 0 5.7 KB
master StartStopWithChild net472 22.3μs 124ns 773ns 0.96 0.32 0.107 6.02 KB
#7691 StartStopWithChild net6.0 10.7μs 45.4ns 176ns 0 0 0 5.52 KB
#7691 StartStopWithChild netcoreapp3.1 13.9μs 63.6ns 238ns 0 0 0 5.74 KB
#7691 StartStopWithChild net472 21.8μs 121ns 804ns 0.992 0.331 0.11 6.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 934μs 141ns 527ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 109ns 408ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.21ms 769ns 2.88μs 0 0 0 3.31 KB
#7691 WriteAndFlushEnrichedTraces net6.0 943μs 208ns 779ns 0 0 0 2.71 KB
#7691 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 371ns 1.44μs 0 0 0 2.7 KB
#7691 WriteAndFlushEnrichedTraces net472 1.18ms 151ns 545ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 354μs 284ns 1.1μs 0 0 0 179.56 KB
master AllCycleSimpleBody netcoreapp3.1 492μs 1.72μs 6.67μs 0 0 0 185.32 KB
master AllCycleSimpleBody net472 469μs 124ns 448ns 32.4 0 0 205.41 KB
master AllCycleMoreComplexBody net6.0 358μs 257ns 995ns 0 0 0 183.09 KB
master AllCycleMoreComplexBody netcoreapp3.1 535μs 1.68μs 6.07μs 0 0 0 188.75 KB
master AllCycleMoreComplexBody net472 479μs 102ns 368ns 32.4 0 0 208.94 KB
master ObjectExtractorSimpleBody net6.0 325ns 1.63ns 7.27ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 392ns 2.19ns 14ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 302ns 0.0224ns 0.0839ns 0.0441 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.25μs 29ns 112ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 8.04μs 33.4ns 129ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.73μs 5.65ns 21.9ns 0.575 0 0 3.8 KB
#7691 AllCycleSimpleBody net6.0 351μs 1.77μs 8.11μs 0 0 0 179.56 KB
#7691 AllCycleSimpleBody netcoreapp3.1 502μs 1.58μs 6.12μs 0 0 0 185.32 KB
#7691 AllCycleSimpleBody net472 468μs 112ns 389ns 32.4 0 0 205.41 KB
#7691 AllCycleMoreComplexBody net6.0 361μs 1.67μs 6.45μs 0 0 0 183.08 KB
#7691 AllCycleMoreComplexBody netcoreapp3.1 536μs 251ns 972ns 0 0 0 188.75 KB
#7691 AllCycleMoreComplexBody net472 478μs 122ns 472ns 32.4 0 0 208.94 KB
#7691 ObjectExtractorSimpleBody net6.0 326ns 1.81ns 8.89ns 0 0 0 280 B
#7691 ObjectExtractorSimpleBody netcoreapp3.1 396ns 2.2ns 12.8ns 0 0 0 272 B
#7691 ObjectExtractorSimpleBody net472 300ns 0.0294ns 0.114ns 0.0438 0 0 281 B
#7691 ObjectExtractorMoreComplexBody net6.0 6.38μs 31.1ns 139ns 0 0 0 3.78 KB
#7691 ObjectExtractorMoreComplexBody netcoreapp3.1 7.94μs 37.7ns 146ns 0 0 0 3.69 KB
#7691 ObjectExtractorMoreComplexBody net472 6.7μs 3.02ns 11.7ns 0.6 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.6μs 144ns 539ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96μs 331ns 1.28μs 0 0 0 32.4 KB
master EncodeArgs net472 110μs 15.6ns 58.3ns 4.93 0 0 32.5 KB
master EncodeLegacyArgs net6.0 147μs 66.2ns 256ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 199μs 180ns 698ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 262μs 42.7ns 165ns 0 0 0 2.16 KB
#7691 EncodeArgs net6.0 77.2μs 388ns 1.65μs 0 0 0 32.4 KB
#7691 EncodeArgs netcoreapp3.1 97.6μs 237ns 918ns 0 0 0 32.4 KB
#7691 EncodeArgs net472 108μs 14ns 54.2ns 4.89 0 0 32.51 KB
#7691 EncodeLegacyArgs net6.0 146μs 7.37ns 27.6ns 0 0 0 2.15 KB
#7691 EncodeLegacyArgs netcoreapp3.1 198μs 185ns 717ns 0 0 0 2.14 KB
#7691 EncodeLegacyArgs net472 263μs 75.6ns 293ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7691

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net472 2.3 KB 2.29 KB -19 B -0.82%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 398μs 59.9ns 224ns 0 0 0 4.56 KB
master RunWafRealisticBenchmark netcoreapp3.1 411μs 160ns 578ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 427μs 47.3ns 183ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 292μs 74.4ns 278ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 298μs 119ns 429ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 315μs 26.8ns 104ns 0 0 0 2.3 KB
#7691 RunWafRealisticBenchmark net6.0 390μs 44.4ns 172ns 0 0 0 4.55 KB
#7691 RunWafRealisticBenchmark netcoreapp3.1 416μs 254ns 916ns 0 0 0 4.48 KB
#7691 RunWafRealisticBenchmark net472 432μs 42.9ns 166ns 0 0 0 4.66 KB
#7691 RunWafRealisticBenchmarkWithAttack net6.0 283μs 61.7ns 222ns 0 0 0 2.24 KB
#7691 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 297μs 44ns 159ns 0 0 0 2.22 KB
#7691 RunWafRealisticBenchmarkWithAttack net472 310μs 30.9ns 120ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.2μs 25.9ns 93.2ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 72.4μs 141ns 546ns 0 0 0 17.42 KB
master SendRequest net472 0.00274ns 0.00108ns 0.00419ns 0 0 0 0 b
#7691 SendRequest net6.0 61.3μs 30.1ns 117ns 0 0 0 14.52 KB
#7691 SendRequest netcoreapp3.1 72.7μs 88.9ns 321ns 0 0 0 17.42 KB
#7691 SendRequest net472 0.00259ns 0.000871ns 0.00326ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7691

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 4 B 1 B -3 B -75.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.87ms 5.75μs 22.3μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.11ms 4.96μs 19.2μs 0 0 0 640 KB
master OriginalCharSlice net472 2.61ms 144ns 537ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.42ms 518ns 2.01μs 0 0 0 7 B
master OptimizedCharSlice netcoreapp3.1 1.73ms 461ns 1.78μs 0 0 0 1 B
master OptimizedCharSlice net472 2.05ms 320ns 1.24μs 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 825μs 23.5ns 91.1ns 0 0 0 4 B
master OptimizedCharSliceWithPool netcoreapp3.1 815μs 166ns 643ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.15ms 125ns 485ns 0 0 0 0 b
#7691 OriginalCharSlice net6.0 1.93ms 1.61μs 6.03μs 0 0 0 640.01 KB
#7691 OriginalCharSlice netcoreapp3.1 2.1ms 5.62μs 21μs 0 0 0 640 KB
#7691 OriginalCharSlice net472 2.73ms 115ns 431ns 100 0 0 641.95 KB
#7691 OptimizedCharSlice net6.0 1.51ms 445ns 1.72μs 0 0 0 7 B
#7691 OptimizedCharSlice netcoreapp3.1 1.71ms 222ns 860ns 0 0 0 1 B
#7691 OptimizedCharSlice net472 2.04ms 359ns 1.39μs 0 0 0 0 b
#7691 OptimizedCharSliceWithPool net6.0 837μs 11.3ns 39.3ns 0 0 0 1 B
#7691 OptimizedCharSliceWithPool netcoreapp3.1 815μs 57.7ns 216ns 0 0 0 1 B
#7691 OptimizedCharSliceWithPool net472 1.15ms 85.6ns 320ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7691

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.12 KB 41.87 KB -244 B -0.58%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.96 KB 41.63 KB -335 B -0.80%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.66 KB 55.44 KB -1.23 KB -2.16%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 671μs 2.88μs 9.98μs 0 0 0 41.96 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 665μs 3.18μs 12.7μs 0 0 0 42.12 KB
master WriteAndFlushEnrichedTraces net472 949μs 4.64μs 19.7μs 8.33 0 0 56.66 KB
#7691 WriteAndFlushEnrichedTraces net6.0 708μs 4.13μs 37.4μs 0 0 0 41.63 KB
#7691 WriteAndFlushEnrichedTraces netcoreapp3.1 706μs 3.73μs 19μs 0 0 0 41.87 KB
#7691 WriteAndFlushEnrichedTraces net472 936μs 5.09μs 34.2μs 4.81 0 0 55.44 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.97μs 0.872ns 3.38ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.59μs 3.06ns 11.9ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.79μs 2.78ns 10.8ns 0.154 0.014 0 987 B
#7691 ExecuteNonQuery net6.0 1.95μs 1.11ns 4.31ns 0 0 0 1.02 KB
#7691 ExecuteNonQuery netcoreapp3.1 2.57μs 13ns 56.7ns 0 0 0 1.02 KB
#7691 ExecuteNonQuery net472 2.9μs 2.43ns 9.39ns 0.143 0.0143 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.78μs 5.47ns 21.2ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.29μs 10.5ns 42.1ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.64μs 1.27ns 4.91ns 0.165 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.97μs 9.48ns 36.7ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.38μs 10.9ns 42.1ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.84μs 2.88ns 10.8ns 0.171 0 0 1.1 KB
#7691 CallElasticsearch net6.0 1.82μs 8.41ns 32.6ns 0 0 0 1.03 KB
#7691 CallElasticsearch netcoreapp3.1 2.25μs 8.01ns 30ns 0 0 0 1.03 KB
#7691 CallElasticsearch net472 3.58μs 3.43ns 13.3ns 0.161 0 0 1.04 KB
#7691 CallElasticsearchAsync net6.0 1.86μs 7.54ns 29.2ns 0 0 0 1.01 KB
#7691 CallElasticsearchAsync netcoreapp3.1 2.41μs 9.98ns 38.6ns 0 0 0 1.08 KB
#7691 CallElasticsearchAsync net472 3.72μs 4.67ns 18.1ns 0.164 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.85μs 8.64ns 34.5ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.35μs 9.3ns 36ns 0 0 0 952 B
master ExecuteAsync net472 2.66μs 7.59ns 29.4ns 0.133 0 0 915 B
#7691 ExecuteAsync net6.0 1.74μs 0.793ns 2.97ns 0 0 0 952 B
#7691 ExecuteAsync netcoreapp3.1 2.47μs 11ns 42.7ns 0 0 0 952 B
#7691 ExecuteAsync net472 2.59μs 5.56ns 21.5ns 0.141 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.8μs 5.5ns 21.3ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.57μs 23.3ns 90.2ns 0 0 0 2.9 KB
master SendAsync net472 12.8μs 10.4ns 40.2ns 0.444 0 0 3.18 KB
#7691 SendAsync net6.0 6.82μs 6.46ns 25ns 0 0 0 2.36 KB
#7691 SendAsync netcoreapp3.1 8.57μs 31.5ns 122ns 0 0 0 2.9 KB
#7691 SendAsync net472 12.4μs 9.04ns 35ns 0.498 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #7691

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 1.132 46,300.00 40,900.00

More allocations ⚠️ in #7691

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 256.77 KB 274.18 KB 17.41 KB 6.78%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 42.82 KB 43.82 KB 1 KB 2.34%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 46.1μs 229ns 1.05μs 0 0 0 42.82 KB
master StringConcatBenchmark netcoreapp3.1 49.6μs 236ns 1.13μs 0 0 0 42.78 KB
master StringConcatBenchmark net472 56.9μs 248ns 993ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 462μs 1.4μs 4.86μs 0 0 0 259.19 KB
master StringConcatAspectBenchmark netcoreapp3.1 485μs 1.42μs 5.11μs 0 0 0 256.77 KB
master StringConcatAspectBenchmark net472 404μs 2.09μs 10.2μs 0 0 0 278.53 KB
#7691 StringConcatBenchmark net6.0 41μs 112ns 405ns 0 0 0 43.82 KB
#7691 StringConcatBenchmark netcoreapp3.1 50.6μs 295ns 2.56μs 0 0 0 42.83 KB
#7691 StringConcatBenchmark net472 56.6μs 245ns 919ns 0 0 0 65.54 KB
#7691 StringConcatAspectBenchmark net6.0 508μs 2.56μs 11.5μs 0 0 0 258.61 KB
#7691 StringConcatAspectBenchmark netcoreapp3.1 515μs 2.09μs 7.55μs 0 0 0 274.18 KB
#7691 StringConcatAspectBenchmark net472 408μs 2μs 8.94μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.58μs 13.4ns 59.8ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.48μs 17.2ns 72.8ns 0 0 0 1.7 KB
master EnrichedLog net472 3.76μs 2.97ns 11.1ns 0.244 0 0 1.64 KB
#7691 EnrichedLog net6.0 2.63μs 7.45ns 28.9ns 0 0 0 1.7 KB
#7691 EnrichedLog netcoreapp3.1 3.54μs 13.5ns 52.2ns 0 0 0 1.7 KB
#7691 EnrichedLog net472 3.81μs 4.8ns 18.6ns 0.246 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 115ns 399ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 128μs 230ns 796ns 0 0 0 4.31 KB
master EnrichedLog net472 166μs 36.3ns 141ns 0 0 0 4.52 KB
#7691 EnrichedLog net6.0 124μs 32.4ns 117ns 0 0 0 4.31 KB
#7691 EnrichedLog netcoreapp3.1 128μs 65ns 234ns 0 0 0 4.31 KB
#7691 EnrichedLog net472 169μs 753ns 2.91μs 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.9μs 4.16ns 16.1ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.83μs 18.1ns 70.2ns 0 0 0 2.26 KB
master EnrichedLog net472 7.73μs 6.89ns 26.7ns 0.31 0 0 2.08 KB
#7691 EnrichedLog net6.0 5.04μs 22ns 85.3ns 0 0 0 2.26 KB
#7691 EnrichedLog netcoreapp3.1 6.88μs 20ns 77.4ns 0 0 0 2.26 KB
#7691 EnrichedLog net472 7.82μs 8.81ns 34.1ns 0.311 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2μs 1.84ns 6.9ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.63μs 8.97ns 34.7ns 0 0 0 1.2 KB
master SendReceive net472 3.2μs 4.56ns 17.7ns 0.178 0 0 1.2 KB
#7691 SendReceive net6.0 1.97μs 7.86ns 29.4ns 0 0 0 1.2 KB
#7691 SendReceive netcoreapp3.1 2.57μs 12.6ns 53.6ns 0 0 0 1.2 KB
#7691 SendReceive net472 3.24μs 6.2ns 24ns 0.179 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.27μs 17.1ns 66.3ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.66μs 14.7ns 57.1ns 0 0 0 1.63 KB
master EnrichedLog net472 6.5μs 6.42ns 24.9ns 0.292 0 0 2.03 KB
#7691 EnrichedLog net6.0 4.16μs 19.5ns 75.7ns 0 0 0 1.58 KB
#7691 EnrichedLog netcoreapp3.1 5.71μs 11.2ns 42ns 0 0 0 1.63 KB
#7691 EnrichedLog net472 6.69μs 10.7ns 41.4ns 0.299 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 793ns 3.83ns 15.8ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 949ns 5.12ns 28.5ns 0 0 0 576 B
master StartFinishSpan net472 924ns 0.173ns 0.649ns 0.088 0 0 578 B
master StartFinishScope net6.0 913ns 0.258ns 1ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.18μs 5.58ns 21.6ns 0 0 0 696 B
master StartFinishScope net472 1.14μs 0.957ns 3.71ns 0.101 0 0 658 B
#7691 StartFinishSpan net6.0 761ns 0.274ns 0.987ns 0 0 0 576 B
#7691 StartFinishSpan netcoreapp3.1 947ns 4.56ns 17.7ns 0 0 0 576 B
#7691 StartFinishSpan net472 902ns 1.75ns 6.76ns 0.09 0 0 578 B
#7691 StartFinishScope net6.0 904ns 4.54ns 20.8ns 0 0 0 696 B
#7691 StartFinishScope netcoreapp3.1 1.17μs 2.24ns 8.67ns 0 0 0 696 B
#7691 StartFinishScope net472 1.12μs 0.0534ns 0.2ns 0.101 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.08μs 4.34ns 16.8ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.46μs 6.27ns 24.3ns 0 0 0 696 B
master RunOnMethodBegin net472 1.43μs 1.83ns 7.1ns 0.0994 0 0 658 B
#7691 RunOnMethodBegin net6.0 1.05μs 5.54ns 27.7ns 0 0 0 696 B
#7691 RunOnMethodBegin netcoreapp3.1 1.41μs 7.41ns 37ns 0 0 0 696 B
#7691 RunOnMethodBegin net472 1.43μs 0.678ns 2.63ns 0.1 0 0 658 B

@lucaspimentel lucaspimentel merged commit abd2b94 into master Oct 21, 2025
149 checks passed
@lucaspimentel lucaspimentel deleted the lpimentel/ignore-local-claude-settings branch October 21, 2025 22:34
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 21, 2025
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.30.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lucaspimentel @bouwkast @andrewlock