Skip to content

[AAP] Add resource name to the collected endpoints#7317

Merged
e-n-0 merged 3 commits into
masterfrom
flavien/upgrade-endpoint-collection
Aug 6, 2025
Merged

[AAP] Add resource name to the collected endpoints#7317
e-n-0 merged 3 commits into
masterfrom
flavien/upgrade-endpoint-collection

Conversation

@e-n-0

@e-n-0 e-n-0 commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Summary of changes

Added the ResourceName to the endpoints collected based on the last update of the RFC.

Reason for change

Implementation details

  • The resource name is defined as method + path except in the case of an endpoint detected as a wildcard, the resource name is set to the path.

Test coverage

Updated the tests.

Other details

#6733

@pr-commenter

pr-commenter Bot commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7317 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.664
  • 5 benchmarks have fewer allocations
  • 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7317

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.02 KB 6.07 KB 53 B 0.88%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11μs 57.1ns 274ns 0 0 0 5.51 KB
master StartStopWithChild netcoreapp3.1 13.8μs 66.5ns 282ns 0 0 0 5.72 KB
master StartStopWithChild net472 21.5μs 97.4ns 351ns 0.997 0.332 0.111 6.02 KB
#7317 StartStopWithChild net6.0 10.4μs 56ns 312ns 0 0 0 5.5 KB
#7317 StartStopWithChild netcoreapp3.1 13.5μs 56ns 217ns 0 0 0 5.72 KB
#7317 StartStopWithChild net472 21.9μs 123ns 842ns 0.96 0.213 0 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 949μs 246ns 921ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.05ms 126ns 490ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.2ms 48ns 186ns 0 0 0 3.31 KB
#7317 WriteAndFlushEnrichedTraces net6.0 933μs 71.1ns 275ns 0 0 0 2.71 KB
#7317 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 60.8ns 219ns 0 0 0 2.7 KB
#7317 WriteAndFlushEnrichedTraces net472 1.21ms 3.24μs 12.6μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 338μs 1.64μs 6.78μs 0 0 0 198.41 KB
master AllCycleSimpleBody netcoreapp3.1 489μs 1.47μs 5.71μs 0 0 0 206.17 KB
master AllCycleSimpleBody net472 449μs 88.8ns 332ns 37.9 2.23 0 246.64 KB
master AllCycleMoreComplexBody net6.0 345μs 684ns 2.65μs 0 0 0 201.92 KB
master AllCycleMoreComplexBody netcoreapp3.1 486μs 1.31μs 5.09μs 0 0 0 209.59 KB
master AllCycleMoreComplexBody net472 458μs 117ns 422ns 37.9 2.23 0 250.15 KB
master ObjectExtractorSimpleBody net6.0 312ns 1.77ns 10.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 404ns 2.1ns 8.91ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 302ns 0.0355ns 0.133ns 0.0439 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.34μs 5.78ns 21.6ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.91μs 8.16ns 31.6ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.72μs 3.06ns 11.9ns 0.601 0 0 3.8 KB
#7317 AllCycleSimpleBody net6.0 330μs 159ns 573ns 0 0 0 197.61 KB
#7317 AllCycleSimpleBody netcoreapp3.1 486μs 1.89μs 7.31μs 0 0 0 205.37 KB
#7317 AllCycleSimpleBody net472 447μs 86.6ns 335ns 37.9 2.23 0 245.55 KB
#7317 AllCycleMoreComplexBody net6.0 338μs 1.47μs 5.69μs 0 0 0 201.11 KB
#7317 AllCycleMoreComplexBody netcoreapp3.1 518μs 155ns 557ns 0 0 0 208.78 KB
#7317 AllCycleMoreComplexBody net472 457μs 160ns 576ns 37.9 2.23 0 249.06 KB
#7317 ObjectExtractorSimpleBody net6.0 325ns 1.61ns 7.01ns 0 0 0 280 B
#7317 ObjectExtractorSimpleBody netcoreapp3.1 408ns 0.212ns 0.819ns 0 0 0 272 B
#7317 ObjectExtractorSimpleBody net472 302ns 0.0404ns 0.156ns 0.0437 0 0 281 B
#7317 ObjectExtractorMoreComplexBody net6.0 6.44μs 22.5ns 87.1ns 0 0 0 3.78 KB
#7317 ObjectExtractorMoreComplexBody netcoreapp3.1 7.75μs 36.8ns 143ns 0 0 0 3.69 KB
#7317 ObjectExtractorMoreComplexBody net472 6.83μs 4.87ns 18.9ns 0.583 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 77.4μs 281ns 1.09μs 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 104μs 502ns 2.01μs 0 0 0 32.4 KB
master EncodeArgs net472 110μs 5.85ns 21.1ns 4.95 0 0 32.51 KB
master EncodeLegacyArgs net6.0 145μs 37.4ns 140ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 200μs 333ns 1.29μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 260μs 39.5ns 142ns 0 0 0 2.16 KB
#7317 EncodeArgs net6.0 77.7μs 218ns 815ns 0 0 0 32.4 KB
#7317 EncodeArgs netcoreapp3.1 98.4μs 279ns 1.08μs 0 0 0 32.4 KB
#7317 EncodeArgs net472 110μs 20.8ns 80.4ns 4.97 0 0 32.51 KB
#7317 EncodeLegacyArgs net6.0 145μs 13.6ns 49ns 0 0 0 2.15 KB
#7317 EncodeLegacyArgs netcoreapp3.1 195μs 56.9ns 213ns 0 0 0 2.14 KB
#7317 EncodeLegacyArgs net472 263μs 27.8ns 108ns 0 0 0 2.17 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7317

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 2.409 301,868.14 727,177.90

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 405μs 30.2ns 113ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 416μs 127ns 476ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 431μs 63.5ns 246ns 0 0 0 4.68 KB
master RunWafRealisticBenchmarkWithAttack net6.0 293μs 77.9ns 302ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 303μs 497ns 1.92μs 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 319μs 27.6ns 103ns 0 0 0 2.29 KB
#7317 RunWafRealisticBenchmark net6.0 391μs 71.2ns 257ns 0 0 0 4.55 KB
#7317 RunWafRealisticBenchmark netcoreapp3.1 409μs 170ns 659ns 0 0 0 4.48 KB
#7317 RunWafRealisticBenchmark net472 431μs 52.5ns 203ns 0 0 0 4.66 KB
#7317 RunWafRealisticBenchmarkWithAttack net6.0 286μs 55.1ns 206ns 0 0 0 2.24 KB
#7317 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 700μs 10.3μs 102μs 0 0 0 2.22 KB
#7317 RunWafRealisticBenchmarkWithAttack net472 309μs 31.4ns 122ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 60.8μs 51.1ns 198ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 72.1μs 380ns 1.86μs 0 0 0 17.42 KB
master SendRequest net472 0.0178ns 0.00274ns 0.0106ns 0 0 0 0 b
#7317 SendRequest net6.0 60.9μs 40.9ns 142ns 0 0 0 14.52 KB
#7317 SendRequest netcoreapp3.1 71μs 35ns 131ns 0 0 0 17.42 KB
#7317 SendRequest net472 0.00964ns 0.000757ns 0.00262ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7317

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 0 b 1 B 1 B ∞

Fewer allocations 🎉 in #7317

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 4 B 3 B -1 B -25.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 7 B 4 B -3 B -42.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.88ms 5.23μs 19.6μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.1ms 6.74μs 24.3μs 0 0 0 640 KB
master OriginalCharSlice net472 2.64ms 136ns 509ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.36ms 337ns 1.31μs 0 0 0 7 B
master OptimizedCharSlice netcoreapp3.1 1.74ms 555ns 2μs 0 0 0 1 B
master OptimizedCharSlice net472 2.14ms 957ns 3.71μs 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 828μs 33.9ns 127ns 0 0 0 4 B
master OptimizedCharSliceWithPool netcoreapp3.1 797μs 96.3ns 373ns 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.14ms 136ns 526ns 0 0 0 0 b
#7317 OriginalCharSlice net6.0 1.96ms 747ns 2.79μs 0 0 0 640.01 KB
#7317 OriginalCharSlice netcoreapp3.1 2.17ms 2.81μs 10.9μs 0 0 0 640 KB
#7317 OriginalCharSlice net472 2.58ms 187ns 725ns 100 0 0 641.95 KB
#7317 OptimizedCharSlice net6.0 1.39ms 315ns 1.22μs 0 0 0 4 B
#7317 OptimizedCharSlice netcoreapp3.1 1.85ms 237ns 917ns 0 0 0 1 B
#7317 OptimizedCharSlice net472 1.95ms 478ns 1.85μs 0 0 0 0 b
#7317 OptimizedCharSliceWithPool net6.0 854μs 36.4ns 141ns 0 0 0 3 B
#7317 OptimizedCharSliceWithPool netcoreapp3.1 834μs 116ns 447ns 0 0 0 1 B
#7317 OptimizedCharSliceWithPool net472 1.16ms 53.4ns 192ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7317

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.150 618,939.84 711,773.12

More allocations ⚠️ in #7317

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.73 KB 56.18 KB 456 B 0.82%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 618μs 1.01μs 3.9μs 0 0 0 41.59 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 711μs 3.35μs 14.2μs 0 0 0 42.06 KB
master WriteAndFlushEnrichedTraces net472 957μs 3.87μs 15μs 4.46 0 0 55.73 KB
#7317 WriteAndFlushEnrichedTraces net6.0 712μs 442ns 1.59μs 0 0 0 41.68 KB
#7317 WriteAndFlushEnrichedTraces netcoreapp3.1 731μs 4.29μs 41.4μs 0 0 0 41.91 KB
#7317 WriteAndFlushEnrichedTraces net472 876μs 2.46μs 9.2μs 8.33 0 0 56.18 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.93μs 9.31ns 38.4ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.58μs 3.06ns 11.9ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.72μs 2.1ns 8.12ns 0.15 0.0136 0 987 B
#7317 ExecuteNonQuery net6.0 1.88μs 8.89ns 33.3ns 0 0 0 1.02 KB
#7317 ExecuteNonQuery netcoreapp3.1 2.59μs 5.57ns 21.6ns 0 0 0 1.02 KB
#7317 ExecuteNonQuery net472 2.75μs 6.53ns 25.3ns 0.151 0.0137 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.76μs 8.04ns 31.1ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.34μs 8.32ns 32.2ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.46μs 1.05ns 3.93ns 0.156 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.81μs 6.69ns 25.9ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.47μs 10.6ns 41.2ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.63μs 6.19ns 24ns 0.161 0 0 1.1 KB
#7317 CallElasticsearch net6.0 1.75μs 6.36ns 23.8ns 0 0 0 1.03 KB
#7317 CallElasticsearch netcoreapp3.1 2.34μs 9.01ns 34.9ns 0 0 0 1.03 KB
#7317 CallElasticsearch net472 3.52μs 2.61ns 10.1ns 0.159 0 0 1.04 KB
#7317 CallElasticsearchAsync net6.0 1.81μs 9.49ns 44.5ns 0 0 0 1.01 KB
#7317 CallElasticsearchAsync netcoreapp3.1 2.51μs 5.73ns 22.2ns 0 0 0 1.08 KB
#7317 CallElasticsearchAsync net472 3.79μs 4.62ns 17.9ns 0.17 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.82μs 0.704ns 2.73ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.38μs 9.87ns 38.2ns 0 0 0 952 B
master ExecuteAsync net472 2.65μs 4.56ns 17.7ns 0.144 0 0 915 B
#7317 ExecuteAsync net6.0 1.87μs 6.28ns 24.3ns 0 0 0 952 B
#7317 ExecuteAsync netcoreapp3.1 2.41μs 5.68ns 22ns 0 0 0 952 B
#7317 ExecuteAsync net472 2.56μs 2.03ns 7.33ns 0.14 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.13μs 25.4ns 94.9ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.55μs 8.83ns 33ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 13ns 50.3ns 0.488 0 0 3.18 KB
#7317 SendAsync net6.0 6.94μs 7.37ns 27.6ns 0 0 0 2.36 KB
#7317 SendAsync netcoreapp3.1 8.45μs 17ns 66ns 0 0 0 2.9 KB
#7317 SendAsync net472 12.4μs 7.62ns 29.5ns 0.493 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7317

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 262.86 KB 276.57 KB 13.71 KB 5.22%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.53 KB 289.35 KB 10.82 KB 3.89%

Fewer allocations 🎉 in #7317

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 275.85 KB 274.46 KB -1.38 KB -0.50%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.78 KB 43.44 KB -336 B -0.77%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 73.73 KB 65.54 KB -8.19 KB -11.11%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 43.7μs 255ns 2.05μs 0 0 0 43.78 KB
master StringConcatBenchmark netcoreapp3.1 48.5μs 246ns 1.28μs 0 0 0 42.68 KB
master StringConcatBenchmark net472 56.6μs 177ns 640ns 0 0 0 73.73 KB
master StringConcatAspectBenchmark net6.0 484μs 2.33μs 9.33μs 0 0 0 262.86 KB
master StringConcatAspectBenchmark netcoreapp3.1 501μs 1.76μs 6.83μs 0 0 0 275.85 KB
master StringConcatAspectBenchmark net472 408μs 2.12μs 10.4μs 0 0 0 278.53 KB
#7317 StringConcatBenchmark net6.0 44.6μs 246ns 1.35μs 0 0 0 43.44 KB
#7317 StringConcatBenchmark netcoreapp3.1 46.8μs 248ns 1.81μs 0 0 0 42.7 KB
#7317 StringConcatBenchmark net472 57.6μs 135ns 504ns 0 0 0 65.54 KB
#7317 StringConcatAspectBenchmark net6.0 474μs 1.64μs 5.93μs 0 0 0 276.57 KB
#7317 StringConcatAspectBenchmark netcoreapp3.1 503μs 1.3μs 5.05μs 0 0 0 274.46 KB
#7317 StringConcatAspectBenchmark net472 406μs 2.23μs 14.1μs 0 0 0 289.35 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.55μs 2.58ns 9.64ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.49μs 16.5ns 68.2ns 0 0 0 1.7 KB
master EnrichedLog net472 3.96μs 2.74ns 10.6ns 0.256 0 0 1.64 KB
#7317 EnrichedLog net6.0 2.59μs 6.72ns 26ns 0 0 0 1.7 KB
#7317 EnrichedLog netcoreapp3.1 3.52μs 16.4ns 65.6ns 0 0 0 1.7 KB
#7317 EnrichedLog net472 4μs 5.28ns 19.8ns 0.259 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 92.7ns 359ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 126μs 62.3ns 225ns 0 0 0 4.31 KB
master EnrichedLog net472 167μs 205ns 795ns 0 0 0 4.51 KB
#7317 EnrichedLog net6.0 122μs 41.2ns 143ns 0 0 0 4.31 KB
#7317 EnrichedLog netcoreapp3.1 127μs 81.2ns 293ns 0 0 0 4.31 KB
#7317 EnrichedLog net472 167μs 83.8ns 314ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.11μs 16.8ns 65.2ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.83μs 12.2ns 47.3ns 0 0 0 2.26 KB
master EnrichedLog net472 7.58μs 6.49ns 25.1ns 0.304 0 0 2.08 KB
#7317 EnrichedLog net6.0 4.97μs 2.94ns 11.4ns 0 0 0 2.26 KB
#7317 EnrichedLog netcoreapp3.1 6.64μs 25.6ns 95.8ns 0 0 0 2.26 KB
#7317 EnrichedLog net472 7.53μs 5.3ns 20.5ns 0.297 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.95μs 10.1ns 46.3ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.62μs 12ns 48.2ns 0 0 0 1.2 KB
master SendReceive net472 3.11μs 1.68ns 6.51ns 0.186 0 0 1.2 KB
#7317 SendReceive net6.0 2.04μs 1.37ns 5.11ns 0 0 0 1.2 KB
#7317 SendReceive netcoreapp3.1 2.63μs 7.13ns 27.6ns 0 0 0 1.2 KB
#7317 SendReceive net472 3.12μs 2.89ns 11.2ns 0.188 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.24μs 8.3ns 32.1ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.55μs 26.1ns 104ns 0 0 0 1.63 KB
master EnrichedLog net472 6.22μs 7.51ns 29.1ns 0.312 0 0 2.03 KB
#7317 EnrichedLog net6.0 4.25μs 15.1ns 58.4ns 0 0 0 1.58 KB
#7317 EnrichedLog netcoreapp3.1 5.5μs 13.3ns 48.1ns 0 0 0 1.63 KB
#7317 EnrichedLog net472 6.44μs 9.68ns 37.5ns 0.322 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 754ns 0.282ns 1.06ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 975ns 4.68ns 18.7ns 0 0 0 576 B
master StartFinishSpan net472 926ns 0.336ns 1.3ns 0.0882 0 0 578 B
master StartFinishScope net6.0 905ns 4.64ns 22.7ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.15μs 5.22ns 20.2ns 0 0 0 696 B
master StartFinishScope net472 1.1μs 1.06ns 4.1ns 0.0997 0 0 658 B
#7317 StartFinishSpan net6.0 761ns 2.8ns 10.8ns 0 0 0 576 B
#7317 StartFinishSpan netcoreapp3.1 999ns 5.36ns 29.4ns 0 0 0 576 B
#7317 StartFinishSpan net472 947ns 0.215ns 0.806ns 0.0899 0 0 578 B
#7317 StartFinishScope net6.0 889ns 4.07ns 15.8ns 0 0 0 696 B
#7317 StartFinishScope netcoreapp3.1 1.14μs 5.91ns 27.7ns 0 0 0 696 B
#7317 StartFinishScope net472 1.13μs 2.94ns 11.4ns 0.102 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.03μs 5.14ns 21.8ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.46μs 4.13ns 16ns 0 0 0 696 B
master RunOnMethodBegin net472 1.37μs 0.496ns 1.92ns 0.103 0 0 658 B
#7317 RunOnMethodBegin net6.0 1.02μs 4.78ns 19.7ns 0 0 0 696 B
#7317 RunOnMethodBegin netcoreapp3.1 1.4μs 6.56ns 27ns 0 0 0 696 B
#7317 RunOnMethodBegin net472 1.39μs 2.22ns 8.61ns 0.104 0 0 658 B

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7317) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7317) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7317) - mean (1,051ms)  : 1018, 1084
     .   : milestone, 1051,
    master - mean (1,048ms)  : 1018, 1077
     .   : milestone, 1048,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7317) - mean (107ms)  : 106, 108
     .   : milestone, 107,
    master - mean (107ms)  : 105, 108
     .   : milestone, 107,

    section Baseline
    This PR (7317) - mean (106ms)  : 103, 109
     .   : milestone, 106,
    master - mean (106ms)  : 104, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7317) - mean (725ms)  : 710, 740
     .   : milestone, 725,
    master - mean (730ms)  : 718, 742
     .   : milestone, 730,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7317) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7317) - mean (93ms)  : 91, 96
     .   : milestone, 93,
    master - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7317) - mean (685ms)  : 663, 706
     .   : milestone, 685,
    master - mean (687ms)  : 670, 705
     .   : milestone, 687,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7317) - mean (93ms)  : 92, 95
     .   : milestone, 93,
    master - mean (94ms)  : 92, 95
     .   : milestone, 94,

    section Baseline
    This PR (7317) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7317) - mean (622ms)  : 610, 634
     .   : milestone, 622,
    master - mean (628ms)  : 617, 638
     .   : milestone, 628,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7317) - mean (193ms)  : 184, 202
     .   : milestone, 193,
    master - mean (193ms)  : 185, 201
     .   : milestone, 193,

    section Baseline
    This PR (7317) - mean (190ms)  : 180, 200
     .   : milestone, 190,
    master - mean (190ms)  : 182, 198
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7317) - mean (1,142ms)  : 1111, 1173
     .   : milestone, 1142,
    master - mean (1,150ms)  : 1118, 1182
     .   : milestone, 1150,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7317) - mean (275ms)  : 266, 283
     .   : milestone, 275,
    master - mean (275ms)  : 267, 284
     .   : milestone, 275,

    section Baseline
    This PR (7317) - mean (273ms)  : 259, 286
     .   : milestone, 273,
    master - mean (275ms)  : 265, 284
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (7317) - mean (914ms)  : 882, 945
     .   : milestone, 914,
    master - mean (919ms)  : 884, 954
     .   : milestone, 919,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7317) - mean (269ms)  : 257, 281
     .   : milestone, 269,
    master - mean (269ms)  : 260, 278
     .   : milestone, 269,

    section Baseline
    This PR (7317) - mean (266ms)  : 257, 276
     .   : milestone, 266,
    master - mean (269ms)  : 260, 279
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7317) - mean (901ms)  : 868, 934
     .   : milestone, 901,
    master - mean (911ms)  : 877, 945
     .   : milestone, 911,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7317) - mean (272ms)  : 265, 280
     .   : milestone, 272,
    master - mean (266ms)  : 258, 275
     .   : milestone, 266,

    section Baseline
    This PR (7317) - mean (264ms)  : 253, 274
     .   : milestone, 264,
    master - mean (267ms)  : 256, 277
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (7317) - mean (810ms)  : 786, 833
     .   : milestone, 810,
    master - mean (813ms)  : 791, 835
     .   : milestone, 813,
Loading

@e-n-0 e-n-0 marked this pull request as ready for review August 2, 2025 16:52
@e-n-0 e-n-0 requested review from a team as code owners August 2, 2025 16:52
andrewlock
andrewlock reviewed Aug 4, 2025
View reviewed changes
Comment thread tracer/src/Datadog.Trace/Telemetry/DTOs/AppEndpointData.cs
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 83ef131 | Docs | Was this helpful? Give us feedback!

daniel-romano-DD
daniel-romano-DD approved these changes Aug 5, 2025
View reviewed changes

@daniel-romano-DD daniel-romano-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@e-n-0 e-n-0 merged commit c38a5fe into master Aug 6, 2025
151 checks passed
@e-n-0 e-n-0 deleted the flavien/upgrade-endpoint-collection branch August 6, 2025 11:43
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 6, 2025
@andrewlock andrewlock added type:enhancement Improvement to an existing feature area:asm labels Aug 11, 2025
@e-n-0 e-n-0 mentioned this pull request Sep 26, 2025
Merged
e-n-0 added a commit that referenced this pull request Sep 29, 2025
@e-n-0
[AAP] Enable by default API Security Endpoints collection when appsec…
fb3ce74 
… enabled (#7569)

## Summary of changes

This PR enable by default the feature to collect all endpoints at
startup when appsec is enabled.

## Other details

See #6733 #7317 for implementation.
<!-- Fixes #{issue} -->


<!--  ⚠️ Note:

Where possible, please obtain 2 approvals prior to merging. Unless
CODEOWNERS specifies otherwise, for external teams it is typically best
to have one review from a team member, and one review from apm-dotnet.
Trivial changes do not require 2 reviews.

MergeQueue is NOT enabled in this repository. If you have write access
to the repo, the PR has 1-2 approvals (see above), and all of the
required checks have passed, you can use the Squash and Merge button to
merge the PR. If you don't have write access, or you need help, reach
out in the #apm-dotnet channel in Slack.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

@daniel-romano-DD daniel-romano-DD daniel-romano-DD approved these changes

Assignees

No one assigned

Labels

area:asm type:enhancement Improvement to an existing feature

Projects

None yet

Milestone

3.24.0

Development

Successfully merging this pull request may close these issues.

3 participants

@e-n-0 @andrewlock @daniel-romano-DD