Make telemetry headers mandatory in tests#6835
Merged
kevingosse merged 1 commit intomasterfrom Apr 11, 2025
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 255678 Passed, 2436 Skipped, 20h 57m 36.63s Total Time |
Member
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6835) - mean (69ms) : 66, 72
. : milestone, 69,
master - mean (69ms) : 67, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6835) - mean (1,011ms) : 978, 1043
. : milestone, 1011,
master - mean (1,010ms) : 981, 1039
. : milestone, 1010,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6835) - mean (103ms) : 100, 106
. : milestone, 103,
master - mean (103ms) : 101, 105
. : milestone, 103,
section CallTarget+Inlining+NGEN
This PR (6835) - mean (694ms) : 674, 715
. : milestone, 694,
master - mean (698ms) : 679, 717
. : milestone, 698,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6835) - mean (90ms) : 88, 92
. : milestone, 90,
master - mean (90ms) : 88, 92
. : milestone, 90,
section CallTarget+Inlining+NGEN
This PR (6835) - mean (651ms) : 631, 672
. : milestone, 651,
master - mean (655ms) : 636, 673
. : milestone, 655,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6835) - mean (189ms) : 185, 194
. : milestone, 189,
master - mean (189ms) : 185, 193
. : milestone, 189,
section CallTarget+Inlining+NGEN
This PR (6835) - mean (1,106ms) : 1077, 1134
. : milestone, 1106,
master - mean (1,107ms) : 1082, 1133
. : milestone, 1107,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6835) - mean (267ms) : 263, 272
. : milestone, 267,
master - mean (268ms) : 263, 272
. : milestone, 268,
section CallTarget+Inlining+NGEN
This PR (6835) - mean (876ms) : 851, 902
. : milestone, 876,
master - mean (879ms) : 843, 916
. : milestone, 879,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6835) - mean (262ms) : 257, 266
. : milestone, 262,
master - mean (260ms) : 257, 263
. : milestone, 260,
section CallTarget+Inlining+NGEN
This PR (6835) - mean (866ms) : 831, 901
. : milestone, 866,
master - mean (869ms) : 836, 902
. : milestone, 869,
|
Datadog ReportBranch report: ✅ 0 Failed, 2 Passed, 0 Skipped, 0s Total Time |
chojomok
pushed a commit
that referenced
this pull request
Jul 15, 2025
## Summary of changes Remove the `OptionalTelemetryHeaders` property from the mock agent. ## Reason for change It was originally added because libdatadog didn't send the proper headers. The latest versions fixed this. ## Implementation details Deleting some code. ## Test coverage This was needed for `CreatedumpTests.SendReportThroughTelemetry`.
andrewlock
added a commit
that referenced
this pull request
Jan 12, 2026
## Summary of changes Removes unused properties and functionality from `MockTelemetryAgent` ## Reason for change Noticed the obsolete behaviour while working on something else. The `OptionalHeaders` option was added as part of the original crashtracking work, and was partially removed as no longer required in #6835, and the parts here were just missed. ## Implementation details Delete unused code ## Test coverage As long as the tests still pass, we're good ## Other details Noticed while working on #8017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Remove the
OptionalTelemetryHeadersproperty from the mock agent.Reason for change
It was originally added because libdatadog didn't send the proper headers. The latest versions fixed this.
Implementation details
Deleting some code.
Test coverage
This was needed for
CreatedumpTests.SendReportThroughTelemetry.