Update .gitlab/one-pipeline.locked.yaml by pawelchcki · Pull Request #6818 · DataDog/dd-trace-dotnet

pawelchcki · 2025-04-03T14:08:09Z

Automatic PR. Updates .gitlab/one-pipeline.locked.yaml

andrewlock

How does this interact with this include? https://github.com/DataDog/dd-trace-dotnet/blob/master/.gitlab-ci.yml#L11

andrewlock

OK, that makes more sense, thanks! 😄

datadog-datadog-prod-us1 · 2025-04-03T14:32:47Z

Datadog Report

Branch report: auto-update-one-pipeline
Commit report: 1ad446c
Test service: dd-trace-dotnet

✅ 0 Failed, 249443 Passed, 2385 Skipped, 21h 15m 22.16s Total Time

andrewlock · 2025-04-03T15:08:25Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6818) - mean (70ms)  : 65, 75
     .   : milestone, 70,
    master - mean (70ms)  : 67, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6818) - mean (1,010ms)  : 991, 1029
     .   : milestone, 1010,
    master - mean (1,007ms)  : 984, 1030
     .   : milestone, 1007,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6818) - mean (103ms)  : 101, 106
     .   : milestone, 103,
    master - mean (103ms)  : 100, 105
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (6818) - mean (691ms)  : 671, 710
     .   : milestone, 691,
    master - mean (686ms)  : 664, 708
     .   : milestone, 686,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6818) - mean (90ms)  : 88, 92
     .   : milestone, 90,
    master - mean (90ms)  : 87, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (6818) - mean (649ms)  : 635, 664
     .   : milestone, 649,
    master - mean (644ms)  : 630, 659
     .   : milestone, 644,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6818) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6818) - mean (1,110ms)  : 1083, 1136
     .   : milestone, 1110,
    master - mean (1,108ms)  : 1071, 1144
     .   : milestone, 1108,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6818) - mean (268ms)  : 266, 271
     .   : milestone, 268,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6818) - mean (875ms)  : 839, 912
     .   : milestone, 875,
    master - mean (872ms)  : 844, 899
     .   : milestone, 872,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6818) - mean (261ms)  : 256, 267
     .   : milestone, 261,
    master - mean (262ms)  : 257, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6818) - mean (862ms)  : 818, 905
     .   : milestone, 862,
    master - mean (856ms)  : 826, 887
     .   : milestone, 856,

andrewlock

Based on this, it looks like this is using https://github.com/DataDog/libdatadog-build/commit/a168809f1e2919f11f318db3df83667230e4d70a as we require, thanks

andrewlock · 2025-04-03T15:16:56Z

@@ -0,0 +1,2 @@
+include:
+  - remote: https://gitlab-templates.ddbuild.io/libdatadog/one-pipeline/ca/05e116339b9780a138a474d0348e97debfca97f27bbc4ca489cf4e4c90d9cc94/one-pipeline.yml


Where does 05e116339b9780a138a474d0348e97debfca97f27bbc4ca489cf4e4c90d9cc94 come from? 🤔 How do we know how and when to update this value?

This is something I need to document. Its a sha of all the files that are exported as part of one-pipeline.

The tooling will automatically detect when this needs to be updated in your Repository (e.g. only when the files change).

andrewlock · 2025-04-03T15:50:08Z

Benchmarks Report for tracer 🐌

Benchmarks for #6818 compared to master:

2 benchmarks are faster, with geometric mean 1.167
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.03μs	42.6ns	213ns	0.0196	0.00782	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	9.91μs	54.2ns	325ns	0.0249	0.00997	0	5.8 KB
master	`StartStopWithChild`	net472	16.2μs	64.8ns	251ns	1.04	0.299	0.102	6.2 KB
#6818	`StartStopWithChild`	net6.0	8μs	42.1ns	223ns	0.0192	0.00769	0	5.61 KB
#6818	`StartStopWithChild`	netcoreapp3.1	10.3μs	54.5ns	362ns	0.0202	0.0101	0	5.8 KB
#6818	`StartStopWithChild`	net472	16.1μs	45.9ns	178ns	1.06	0.336	0.104	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	506μs	573ns	2.22μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	652μs	487ns	1.69μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	862μs	1.31μs	4.92μs	0.428	3.3 KB
#6818	`WriteAndFlushEnrichedTraces`	net6.0	486μs	568ns	2.2μs	0	2.7 KB
#6818	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	650μs	453ns	1.76μs	0	2.7 KB
#6818	`WriteAndFlushEnrichedTraces`	net472	861μs	467ns	1.75μs	0.431	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	130μs	587ns	2.27μs	0.203	14.47 KB
master	`SendRequest`	netcoreapp3.1	147μs	270ns	1.04μs	0.221	17.27 KB
master	`SendRequest`	net472	0.000696ns	0.000371ns	0.00139ns	0	0 b
#6818	`SendRequest`	net6.0	131μs	496ns	1.92μs	0.197	14.47 KB
#6818	`SendRequest`	netcoreapp3.1	146μs	363ns	1.41μs	0.216	17.27 KB
#6818	`SendRequest`	net472	0.000906ns	0.000472ns	0.00176ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	621μs	3.45μs	27μs	0.556	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	743μs	5.22μs	51.4μs	0.403	0	0	41.83 KB
master	`WriteAndFlushEnrichedTraces`	net472	854μs	3.69μs	14.3μs	8.39	2.52	0.419	53.28 KB
#6818	`WriteAndFlushEnrichedTraces`	net6.0	623μs	4.71μs	45.9μs	0.631	0	0	41.63 KB
#6818	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	743μs	4.22μs	31.9μs	0.361	0	0	41.78 KB
#6818	`WriteAndFlushEnrichedTraces`	net472	877μs	4.26μs	17.6μs	8.04	2.23	0.446	53.32 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.26μs	1.81ns	7.02ns	0.0144	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	1.39ns	5.2ns	0.014	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.11μs	2.3ns	8.93ns	0.156	0.00105	987 B
#6818	`ExecuteNonQuery`	net6.0	1.39μs	1.62ns	6.28ns	0.0139	0	1.02 KB
#6818	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	1.44ns	5.56ns	0.0134	0	1.02 KB
#6818	`ExecuteNonQuery`	net472	2.08μs	3.53ns	13.2ns	0.156	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.27μs	0.723ns	2.8ns	0.0133	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.59μs	0.763ns	2.86ns	0.0127	976 B
master	`CallElasticsearch`	net472	2.69μs	1.38ns	5.33ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.25μs	0.362ns	1.35ns	0.0129	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	1.84ns	6.89ns	0.0134	1.02 KB
master	`CallElasticsearchAsync`	net472	2.67μs	1.05ns	3.91ns	0.167	1.05 KB
#6818	`CallElasticsearch`	net6.0	1.16μs	0.653ns	2.53ns	0.0139	976 B
#6818	`CallElasticsearch`	netcoreapp3.1	1.57μs	0.793ns	2.97ns	0.0134	976 B
#6818	`CallElasticsearch`	net472	2.65μs	1.14ns	4.28ns	0.158	995 B
#6818	`CallElasticsearchAsync`	net6.0	1.34μs	0.893ns	3.34ns	0.0133	952 B
#6818	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.776ns	2.91ns	0.0139	1.02 KB
#6818	`CallElasticsearchAsync`	net472	2.64μs	0.749ns	2.7ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.24μs	0.81ns	3.03ns	0.0137	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.599ns	2.24ns	0.0123	952 B
master	`ExecuteAsync`	net472	1.9μs	0.685ns	2.47ns	0.145	915 B
#6818	`ExecuteAsync`	net6.0	1.17μs	0.962ns	3.6ns	0.0135	952 B
#6818	`ExecuteAsync`	netcoreapp3.1	1.7μs	1.41ns	5.47ns	0.0128	952 B
#6818	`ExecuteAsync`	net472	1.87μs	0.568ns	2.2ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.23μs	1.13ns	4.25ns	0.0318	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.38μs	1.32ns	4.95ns	0.0377	2.85 KB
master	`SendAsync`	net472	7.43μs	1.62ns	6.05ns	0.494	3.12 KB
#6818	`SendAsync`	net6.0	4.38μs	2.36ns	8.83ns	0.0307	2.31 KB
#6818	`SendAsync`	netcoreapp3.1	5.28μs	2.31ns	8.95ns	0.0396	2.85 KB
#6818	`SendAsync`	net472	7.42μs	1.25ns	4.66ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.52μs	0.725ns	2.81ns	0.0236	1.69 KB
master	`EnrichedLog`	netcoreapp3.1	2.3μs	0.922ns	3.57ns	0.0229	1.69 KB
master	`EnrichedLog`	net472	2.79μs	1.8ns	6.97ns	0.258	1.62 KB
#6818	`EnrichedLog`	net6.0	1.58μs	0.658ns	2.55ns	0.0239	1.69 KB
#6818	`EnrichedLog`	netcoreapp3.1	2.35μs	0.957ns	3.58ns	0.0222	1.69 KB
#6818	`EnrichedLog`	net472	2.57μs	1.37ns	5.14ns	0.258	1.62 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	112μs	162ns	627ns	0.0556	0	4.3 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	194ns	725ns	0	0	4.3 KB
master	`EnrichedLog`	net472	151μs	151ns	584ns	0.675	0.225	4.49 KB
#6818	`EnrichedLog`	net6.0	113μs	122ns	472ns	0.0561	0	4.3 KB
#6818	`EnrichedLog`	netcoreapp3.1	118μs	147ns	568ns	0	0	4.3 KB
#6818	`EnrichedLog`	net472	150μs	121ns	468ns	0.675	0.225	4.49 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.22μs	0.799ns	3.09ns	0.0306	2.25 KB
master	`EnrichedLog`	netcoreapp3.1	4.28μs	1.11ns	4ns	0.0302	2.25 KB
master	`EnrichedLog`	net472	4.93μs	1.53ns	5.94ns	0.328	2.07 KB
#6818	`EnrichedLog`	net6.0	2.95μs	1.13ns	4.37ns	0.0309	2.25 KB
#6818	`EnrichedLog`	netcoreapp3.1	4.19μs	1.89ns	6.81ns	0.0314	2.25 KB
#6818	`EnrichedLog`	net472	4.92μs	1.94ns	7.53ns	0.327	2.07 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.38μs	0.414ns	1.6ns	0.0158	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.92μs	0.603ns	2.33ns	0.0153	1.14 KB
master	`SendReceive`	net472	2.09μs	1.22ns	4.56ns	0.183	1.16 KB
#6818	`SendReceive`	net6.0	1.48μs	1.31ns	5.07ns	0.0162	1.14 KB
#6818	`SendReceive`	netcoreapp3.1	1.78μs	0.799ns	3.1ns	0.0152	1.14 KB
#6818	`SendReceive`	net472	2.18μs	1.36ns	5.27ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.88μs	0.942ns	3.65ns	0.023	1.62 KB
master	`EnrichedLog`	netcoreapp3.1	4.05μs	1.62ns	6.29ns	0.0222	1.67 KB
master	`EnrichedLog`	net472	4.42μs	4.06ns	15.2ns	0.327	2.07 KB
#6818	`EnrichedLog`	net6.0	3.02μs	0.741ns	2.67ns	0.0227	1.62 KB
#6818	`EnrichedLog`	netcoreapp3.1	4.12μs	1.54ns	5.97ns	0.0226	1.67 KB
#6818	`EnrichedLog`	net472	4.54μs	1.03ns	3.56ns	0.327	2.07 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6818

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.137	541.43	476.32

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	407ns	0.179ns	0.695ns	0.00816	576 B
master	`StartFinishSpan`	netcoreapp3.1	607ns	0.299ns	1.12ns	0.0079	576 B
master	`StartFinishSpan`	net472	655ns	0.599ns	2.32ns	0.0918	578 B
master	`StartFinishScope`	net6.0	541ns	0.133ns	0.498ns	0.00978	696 B
master	`StartFinishScope`	netcoreapp3.1	688ns	0.456ns	1.77ns	0.00928	696 B
master	`StartFinishScope`	net472	878ns	0.235ns	0.909ns	0.104	658 B
#6818	`StartFinishSpan`	net6.0	433ns	0.124ns	0.482ns	0.00801	576 B
#6818	`StartFinishSpan`	netcoreapp3.1	638ns	0.649ns	2.51ns	0.00773	576 B
#6818	`StartFinishSpan`	net472	665ns	0.579ns	2.24ns	0.0916	578 B
#6818	`StartFinishScope`	net6.0	476ns	0.11ns	0.425ns	0.00965	696 B
#6818	`StartFinishScope`	netcoreapp3.1	728ns	0.244ns	0.946ns	0.00944	696 B
#6818	`StartFinishScope`	net472	887ns	0.256ns	0.991ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6818

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.199	803.66	670.28

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	803ns	0.404ns	1.56ns	0.00965	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	917ns	0.537ns	2.01ns	0.00964	696 B
master	`RunOnMethodBegin`	net472	1.14μs	0.361ns	1.4ns	0.105	658 B
#6818	`RunOnMethodBegin`	net6.0	670ns	0.315ns	1.22ns	0.00974	696 B
#6818	`RunOnMethodBegin`	netcoreapp3.1	903ns	0.345ns	1.33ns	0.00924	696 B
#6818	`RunOnMethodBegin`	net472	1.08μs	0.345ns	1.29ns	0.105	658 B

Automatic PR. Updates .gitlab/one-pipeline.locked.yaml

Update .gitlab/one-pipeline.locked.yaml

0d19274

pawelchcki requested a review from a team as a code owner April 3, 2025 14:08

andrewlock approved these changes Apr 3, 2025

View reviewed changes

Update .gitlab-ci.yml to point to the new OnePipeline file

1ad446c

andrewlock approved these changes Apr 3, 2025

View reviewed changes

pawelchcki merged commit 2b5c978 into master Apr 3, 2025

pawelchcki deleted the auto-update-one-pipeline branch April 3, 2025 18:45

github-actions Bot added this to the vNext-v3 milestone Apr 3, 2025

andrewlock pushed a commit that referenced this pull request Apr 9, 2025

Update .gitlab/one-pipeline.locked.yaml (#6818)

c75cf09

Automatic PR. Updates .gitlab/one-pipeline.locked.yaml

bouwkast added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 21, 2025

chojomok pushed a commit that referenced this pull request Jul 15, 2025

Update .gitlab/one-pipeline.locked.yaml (#6818)

a4ce704

Automatic PR. Updates .gitlab/one-pipeline.locked.yaml

		@@ -0,0 +1,2 @@
		include:
		- remote: https://gitlab-templates.ddbuild.io/libdatadog/one-pipeline/ca/05e116339b9780a138a474d0348e97debfca97f27bbc4ca489cf4e4c90d9cc94/one-pipeline.yml

Conversation

pawelchcki commented Apr 3, 2025

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 Bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

andrewlock commented Apr 3, 2025

Execution-Time Benchmarks Report ⏱️

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

andrewlock Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

pawelchcki Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

andrewlock commented Apr 3, 2025

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6818

Raw results

Faster 🎉 in #6818

Raw results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-datadog-prod-us1 Bot commented Apr 3, 2025 •

edited

Loading