Skip to content

Enable custom sampling rule variable#585

Merged
colin-higgins merged 4 commits into
masterfrom
colin/enable-custom-sampling-rule
Dec 10, 2019
Merged

Enable custom sampling rule variable#585
colin-higgins merged 4 commits into
masterfrom
colin/enable-custom-sampling-rule

Conversation

@colin-higgins

@colin-higgins colin-higgins commented Dec 10, 2019 •
edited by lucaspimentel
Loading

Copy link
Copy Markdown
Member
  • fix not reading custom sample rules from configuration sources
  • add missing Datadog.Trace.AspNet.dll to msi
  • version bump to 1.10.2-prerelease

@colin-higgins colin-higgins requested a review from a team as a code owner December 10, 2019 19:47
@colin-higgins colin-higgins self-assigned this Dec 10, 2019
@lucaspimentel lucaspimentel added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:bug labels Dec 10, 2019
@lucaspimentel lucaspimentel added this to the 1.11.0 milestone Dec 10, 2019
colin-higgins
colin-higgins commented Dec 10, 2019
View reviewed changes
Comment thread src/Datadog.Trace/Configuration/TracerSettings.cs
// default value
false;

CustomSamplingRules = source?.GetString(ConfigurationKeys.CustomSamplingRules) ??

@colin-higgins colin-higgins Dec 10, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enables pulling the variable

@lucaspimentel lucaspimentel added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 10, 2019
colin-higgins
colin-higgins commented Dec 10, 2019
View reviewed changes
Comment thread performance/Performance.StackExchange.Redis/Program.cs
{
var benchmarkDate = DateTime.Now;

#if DEBUG

@colin-higgins colin-higgins Dec 10, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test code for verifying the variable

@lucaspimentel lucaspimentel added the area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) label Dec 10, 2019
@colin-higgins colin-higgins merged commit 47c3847 into master Dec 10, 2019
@colin-higgins colin-higgins deleted the colin/enable-custom-sampling-rule branch December 10, 2019 19:55
MikeGoldsmith pushed a commit to lightstep/ls-trace-dotnet that referenced this pull request Mar 20, 2020
@colin-higgins @MikeGoldsmith
v1.10.2-prerelease -> Enable custom sampling rule variable (DataDog#585)
6c4ae44 
* add debug option for load test, enable custom sample rules env var, up the version, update the wix project dependencies
macrogreg pushed a commit that referenced this pull request Aug 20, 2021
@colin-higgins
v1.10.2-prerelease -> Enable custom sampling rule variable (#585)
37fcbf4 
* add debug option for load test, enable custom sample rules env var, up the version, update the wix project dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

Assignees

@colin-higgins colin-higgins

Labels

area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) area:builds project files, build scripts, pipelines, versioning, releases, packages area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:bug

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@colin-higgins @lucaspimentel