Enable prerelease version tags, bump to v1.9.1-prerelease#556
Conversation
|
Before we merge this, let's manually run MSI tests including upgrading to make sure it works as expected. |
bobuva
left a comment
There was a problem hiding this comment.
LGTM, see my comment about manual MSI tests
|
@bobuva The only thing that changes in this PR is the nuget packaging. I'll test the MSI after making the versioning changes we talked about, for basing the MSI verison on something hard coded. |
|
@colin-higgins Sorry, I wasn't clear if this PR would address the MSI versioning, but if you were going to tackle that, you could either hard-code the version directly in |
|
Maybe it would just be easier to set the values in |
|
And yet another suggestion, maybe just remove the |
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>net452;net461;netcoreapp2.1;netcoreapp3.0</TargetFrameworks> |
There was a problem hiding this comment.
nit: These can probably be reduced to something like net45;netstandard2.0 but no need to block on this.
zacharycmontoya
left a comment
There was a problem hiding this comment.
LGTM, I'm so happy that now everything will be defined in source code 😄
|
Just need to update the release docs... :D |
* Enable prerelease format, bump to v1.9.1-prerelease
* Enable prerelease format, bump to v1.9.1-prerelease
* Enable prerelease format, bump to v1.9.1-prerelease
v1.9.1-prerelease
@DataDog/apm-dotnet