Skip to content

Using stream instead of strings to send appsec data to agent#1664

Merged
anna-git merged 5 commits into
appsec/v0-integrationfrom
appsec/anna/v0-integration-stringtostream-senddata
Aug 6, 2021
Merged

Using stream instead of strings to send appsec data to agent#1664
anna-git merged 5 commits into
appsec/v0-integrationfrom
appsec/anna/v0-integration-stringtostream-senddata

Conversation

@anna-git

@anna-git anna-git commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

Fixes #

Changes proposed in this pull request:

  • Using streams instead of strings before sending app sec events (for serializing and filling request stream)
  • Taking into account transport strategy in case HttpStreamRequest is wanted
  • Fixing integrations.json where asp.net core middleware integration disappears
  • Logging wrong response codes
  • Using one json serializer for all requests

@DataDog/apm-dotnet

@anna-git anna-git marked this pull request as ready for review August 5, 2021 17:15
@anna-git anna-git requested a review from a team as a code owner August 5, 2021 17:15
@anna-git anna-git requested a review from robertpi August 5, 2021 17:15
@anna-git anna-git merged commit b4a1725 into appsec/v0-integration Aug 6, 2021
@anna-git anna-git deleted the appsec/anna/v0-integration-stringtostream-senddata branch August 6, 2021 15:18
anna-git added a commit that referenced this pull request Aug 9, 2021
* using stream instead of strings

* Fixing shortened json

* Updating message if environment not supported

* Taking into account transport mode for agent writer

* Fix Fake api dont change order methods
robertpi pushed a commit that referenced this pull request Aug 10, 2021
* using stream instead of strings

* Fixing shortened json

* Updating message if environment not supported

* Taking into account transport mode for agent writer

* Fix Fake api dont change order methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant