Enable security only if initialization process OK#1660
Merged
anna-git merged 3 commits intoAug 5, 2021
Conversation
4d66c59 to
9129e85
Compare
2468980 to
d94650e
Compare
robertpi
approved these changes
Aug 5, 2021
robertpi
left a comment
Member
There was a problem hiding this comment.
One small comment, otherwise it's good.
| } | ||
| } | ||
| } | ||
| catch (Exception ex) |
Member
There was a problem hiding this comment.
Should probably set Enabled = false in this catch block too.
anna-git
added a commit
that referenced
this pull request
Aug 9, 2021
* Initialize security components only if no waf loading problem, otherwise disable security * Disable Security if some initialization fails * Disable security in case of exception in constructor
robertpi
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Initialize security components only if no waf loading problem, otherwise disable security * Disable Security if some initialization fails * Disable security in case of exception in constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this pull request:
Enable security only if initialization process OK
Small fixes
@DataDog/apm-dotnet