Changes to share iis fixture with security integration tests#1648
Merged
anna-git merged 5 commits intoAug 2, 2021
Merged
Conversation
Remove env variables Dot not reference System.EnterpriseServices if not net framework Add Applicationhost.config Class should be abstract so that it doesnt want to directly play the test in it Remove shutdown path Dont add call site tests : officially not supported Rename test security
robertpi
approved these changes
Jul 30, 2021
anna-git
added a commit
that referenced
this pull request
Aug 2, 2021
This PR cleans up our integration tests by sharing some infrastructure bits coming from Datadog.Trace.ClrProfiler.IntegrationTests, adding the common parts to the TestHelper project. Dot not reference System.EnterpriseServices if not net framework Add Applicationhost.config Class should be abstract so that it doesnt want to directly play the test in it Remove shutdown path Dont add call site tests : officially not supported Rename test security * Adapting to blocking enabled or not * set http port * Fixing asserts * Removing some logging Co-authored-by: Robert Pickering <robert@sqreen.io>
anna-git
added a commit
that referenced
this pull request
Aug 4, 2021
This PR cleans up our integration tests by sharing some infrastructure bits coming from Datadog.Trace.ClrProfiler.IntegrationTests, adding the common parts to the TestHelper project. Dot not reference System.EnterpriseServices if not net framework Add Applicationhost.config Class should be abstract so that it doesnt want to directly play the test in it Remove shutdown path Dont add call site tests : officially not supported Rename test security * Adapting to blocking enabled or not * set http port * Fixing asserts * Removing some logging Co-authored-by: Robert Pickering <robert@sqreen.io>
anna-git
added a commit
that referenced
this pull request
Aug 9, 2021
This PR cleans up our integration tests by sharing some infrastructure bits coming from Datadog.Trace.ClrProfiler.IntegrationTests, adding the common parts to the TestHelper project. Dot not reference System.EnterpriseServices if not net framework Add Applicationhost.config Class should be abstract so that it doesnt want to directly play the test in it Remove shutdown path Dont add call site tests : officially not supported Rename test security * Adapting to blocking enabled or not * set http port * Fixing asserts * Removing some logging Co-authored-by: Robert Pickering <robert@sqreen.io>
robertpi
added a commit
that referenced
this pull request
Aug 10, 2021
This PR cleans up our integration tests by sharing some infrastructure bits coming from Datadog.Trace.ClrProfiler.IntegrationTests, adding the common parts to the TestHelper project. Dot not reference System.EnterpriseServices if not net framework Add Applicationhost.config Class should be abstract so that it doesnt want to directly play the test in it Remove shutdown path Dont add call site tests : officially not supported Rename test security * Adapting to blocking enabled or not * set http port * Fixing asserts * Removing some logging Co-authored-by: Robert Pickering <robert@sqreen.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this pull request:
Have iisfixture and gacfixture shared with Security integration tests to harmonize with other integration tests
@DataDog/apm-dotnet