Skip building Samples.OracleMDA.* projects#1477
Merged
Merged
Conversation
This was referenced May 19, 2021
lucaspimentel
commented
May 19, 2021
Comment on lines
-81
to
-94
| }, | ||
| { | ||
| "IntegrationName": "OracleMDA", | ||
| "SampleProjectName": "Samples.OracleMDA", | ||
| "NugetPackageSearchName": "Oracle.ManagedDataAccess", | ||
| "MinVersion": "18.3.0", | ||
| "MaxVersionExclusive": "20.0.0" | ||
| }, | ||
| { | ||
| "IntegrationName": "OracleMDACore", | ||
| "SampleProjectName": "Samples.OracleMDA.Core", | ||
| "NugetPackageSearchName": "Oracle.ManagedDataAccess.Core", | ||
| "MinVersion": "2.18.3", | ||
| "MaxVersionExclusive": "3.0.0" |
lucaspimentel
commented
May 19, 2021
|
|
||
| dotnet publish -f $publishTargetFramework -c $buildConfiguration test/test-applications/instrumentation/CallTargetNativeTest/CallTargetNativeTest.csproj -p:Configuration=$buildConfiguration -p:ManagedProfilerOutputDirectory="$PUBLISH_OUTPUT" | ||
|
|
||
| for sample in Samples.Elasticsearch Samples.Elasticsearch.V5 Samples.ServiceStack.Redis Samples.StackExchange.Redis Samples.SqlServer Samples.Microsoft.Data.SqlClient Samples.MongoDB Samples.HttpMessageHandler Samples.WebRequest Samples.Npgsql Samples.MySql Samples.GraphQL Samples.Dapper Samples.NoMultiLoader Samples.RabbitMQ Samples.RuntimeMetrics Samples.FakeDbCommand Samples.Microsoft.Data.Sqlite Samples.SQLite.Core Samples.OracleMDA Samples.OracleMDA.Core ; do |
Member
|
I think this is fine if it unblocks you, but also, it's pretty bad we're not running this in CI. AFACIT we can run Oracle in Docker, so is it just a licensing issue? If so, is it worth looking into testing directly against their cloud, e.g. using their free tier. Even if we only ran it nightly (to avoid outages or flakiness blocking CI etc)? |
tonyredondo
approved these changes
May 20, 2021
zacharycmontoya
approved these changes
May 21, 2021
zacharycmontoya
left a comment
Contributor
There was a problem hiding this comment.
LGTM. This is worth creating an internal ticket so we are aware of this testing gap
… scripts keep the projects around because we may use them later
01565c4 to
badae75
Compare
Member
Author
|
/azp run runner |
zacharycmontoya
pushed a commit
that referenced
this pull request
Jun 11, 2021
* remove unused Samples.OracleMDA and Samples.OracleMDA.Core from build scripts * run GeneratePackageVersions tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
Samples.OracleMDAandSamples.OracleMDA.Corefrom build scripts. We don't use them and they are causing issues with the build in #1468. We still need to figure out how to run them in CI anyway, and hopefully by that point we'll have build scripts that are easier to work with (see #1476).Notes:
GeneratePackageVersionstool.