Replace builtin json with faster ujson package.#469
Merged
purple4reina merged 3 commits intomainfrom Apr 11, 2024
Merged
Conversation
astuyve
requested changes
Apr 10, 2024
Contributor
astuyve
left a comment
There was a problem hiding this comment.
Needs to be added to the LICENSE-3rdparty.csv file, otherwise it's good
astuyve
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces instances of the builtin
jsonpackage to useujsoninstead.Motivation
The builtin
jsonpackage is pretty slow for loading/dumping data. There are faster alternatives.Testing Guidelines
Additional Notes
I evaluated several packages to determine which was best.
jsonujsonmsgspecorjsonrapidjsonsimplejson* "total mean bench" is the sum of all the mean durations of all benchmarks.
Some packages were faster/slower depending on the lambda event payload. But I ultimately went with
ujsonbecause it is generally one of the fastest, plus has smallest package size.Some benchmark results
Comparison of
jsonandujsonwhen extracting trace context from an sqs batch event.Curling lambda url with capture lambda payload true.
Types of Changes
Check all that apply