fix: use RouteKey in resource path for API Gateway inferred spans#442
Merged
purple4reina merged 5 commits intomainfrom Mar 29, 2024
Merged
fix: use RouteKey in resource path for API Gateway inferred spans#442purple4reina merged 5 commits intomainfrom
purple4reina merged 5 commits intomainfrom
Conversation
zARODz11z
commented
Mar 13, 2024
datadog_lambda/tracing.py
Outdated
| method = event.get("httpMethod") | ||
| path = event.get("path") | ||
| resource = "{0} {1}".format(method, path) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
fc1b414 to
0f16ebb
Compare
duncanista
reviewed
Mar 28, 2024
| path = event.get("path") | ||
| resource = "{0} {1}".format(method, path) | ||
| resource_path = _get_resource_path(event, request_context) | ||
| resource = "{0} {1}".format(method, resource_path) |
Contributor
There was a problem hiding this comment.
Let's use f string, instead of format. Due to performance.
| path = event.get("rawPath") | ||
| resource = "{0} {1}".format(method, path) | ||
| resource_path = _get_resource_path(event, request_context) | ||
| resource = "{0} {1}".format(method, resource_path) |
duncanista
approved these changes
Mar 29, 2024
Contributor
duncanista
left a comment
There was a problem hiding this comment.
LGTM – thanks for addressing performance regression on another PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Normalizes the apigw inferred span resource name
Motivation
SVLS-4006
Testing Guidelines
I built the python layer and manually tested it, here is the outcome
Additional Notes
Types of Changes
Check all that apply