Skip to content

feat: Signing job should run as one-shot or loop over layers#432

Merged
astuyve merged 1 commit intomainfrom
aj/fix-signer-arch
Mar 6, 2024
Merged

feat: Signing job should run as one-shot or loop over layers#432
astuyve merged 1 commit intomainfrom
aj/fix-signer-arch

Conversation

@astuyve
Copy link
Copy Markdown
Contributor

@astuyve astuyve commented Mar 6, 2024

What does this PR do?

The signing job now runs a layer in one shot as part of a generated matrix, but for govcloud it also must run for all supported runtimes.
This allows it to do both.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner March 6, 2024 15:58
Copy link
Copy Markdown
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astuyve astuyve merged commit a132b04 into main Mar 6, 2024
@astuyve astuyve deleted the aj/fix-signer-arch branch March 6, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants