[SVLS-8477] ensure consistency for WEBSITES_ENABLE_APP_SERVICE_STORAGE#2084
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 5b4be41 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
| // Get base environment variables | ||
| let envVars = getBaseEnvVars(config) | ||
| envVars = { | ||
| WEBSITES_ENABLE_APP_SERVICE_STORAGE: 'true', |
There was a problem hiding this comment.
I'm not super familiar with this specifically, but is there any risk associated changing this without customers knowing?
AI overview said this about turning it to true:
Files written to /home (including subdirectories like /home/site/wwwroot, LogFiles, etc.) will persist across app restarts and scale instances.
Which makes it sound like this could cause stored files to build up or state to act differently
There was a problem hiding this comment.
Discussed offline -- the TLDR is logging won't work without this environment variable so regardless of how the customer has configured their app, this is necessary.
What and why?
After some discussions with support and other folks, we should make sure we're consistent about ensuring the
WEBSITES_ENABLE_APP_SERVICE_STORAGEenv var is set to true, since the default value is not always set properly.How?
Always add WEBSITES_ENABLE_APP_SERVICE_STORAGE, since it can fix logging issues but doesn't hurt to do.
Review checklist