Skip to content

Revert "Extend progressive cache to bazel-managed Go and pip (#47007)"#47083

Merged
rdesgroppes merged 1 commit intomainfrom
regis.desgroppes/disable-go-cache
Feb 28, 2026
Merged

Revert "Extend progressive cache to bazel-managed Go and pip (#47007)"#47083
rdesgroppes merged 1 commit intomainfrom
regis.desgroppes/disable-go-cache

Conversation

@rdesgroppes
Copy link
Copy Markdown
Contributor

@rdesgroppes rdesgroppes commented Feb 27, 2026

What does this PR do?

This reverts commit 16eda26.

Motivation

#incident-50242

@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Feb 27, 2026
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Feb 27, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 27, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Feb 27, 2026

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 110 0 0

ℹ️ Diff available in the job log.

@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/disable-go-cache branch from 834231c to a63463c Compare February 27, 2026 23:41
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/disable-go-cache branch from a63463c to 03ac638 Compare February 27, 2026 23:57
@rdesgroppes rdesgroppes marked this pull request as ready for review February 28, 2026 00:01
@rdesgroppes rdesgroppes requested a review from a team as a code owner February 28, 2026 00:01
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 436252f9:

Results for datadog-agent_7.78.0~devel.git.195.03ac638.pipeline.99584114-1_amd64.deb:

No change detected

@rdesgroppes rdesgroppes merged commit 764874e into main Feb 28, 2026
257 checks passed
@rdesgroppes rdesgroppes deleted the regis.desgroppes/disable-go-cache branch February 28, 2026 01:14
@github-actions github-actions bot added this to the 7.78.0 milestone Feb 28, 2026
rdesgroppes added a commit that referenced this pull request Mar 2, 2026
What does this PR do?
Partially restores #47007, which was fully reverted in #47083 due to
#incident-50242: only the absolute-path validation on XDG_CACHE_HOME is
reinstated.
In particular, the GOCACHE wiring that caused the incident is left out.

Motivation
A relative XDG_CACHE_HOME is silently accepted by the existing
directory-existence check and would be used as-is, leading to
cache misses or wrong paths depending on the working directory.
gh-worker-dd-mergequeue-cf854d bot pushed a commit that referenced this pull request Mar 3, 2026
### What does this PR do?
Very partially restores #47007, which was fully reverted in #47083 due to #incident-50242:
- only the absolute-path validation on XDG_CACHE_HOME is reinstated,
- in particular, the GOCACHE wiring that caused the incident is left out.

### Motivation
A relative XDG_CACHE_HOME is silently accepted by the existing directory-existence check and would be used as-is, leading to cache misses or wrong paths depending on the working directory (see #47007)..

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
rdesgroppes added a commit that referenced this pull request Mar 4, 2026
### What does this PR do?
Reapply #47007, reverted in #47083 following #incident-50242, but with
the following adjustments:
1. scope repository caches to individual jobs (`$CI_JOB_NAME`) rather
   than runner types (`$CI_RUNNER_DESCRIPTION`),
2. add `.cache/ms-go*` to the cached paths (neutral until `msgo` 1.26+).

### Motivation
#incident-50242 traced to FIPS and non-FIPS omnibus jobs racing to write
incompatible Go build artifacts to the same cache key: `msgo` tags
indeed compile objects with `X:systemcrypto` while upstream Go does not.

It turns out to be a **known issue**: microsoft/go#1994.

Until the corresponding fix is available (microsoft/go#1998), that is
when bumping the Go SDK version to 1.26+, the main adjustment consists
in temporarily scoping repository caches to jobs.
Per-job cache keys naturally segregate the two without requiring an
explicit FIPS discriminator (we couldn't rely on `$FLAVOR` because it's
not expanding consistently across jobs).

### Additional Notes
When switching to Go SDK 1.26+, we'll revert `$CI_RUNNER_DESCRIPTION`
because `msgo` 1.26+ will eliminate the conflict at the toolchain level
thanks to microsoft/go#1998.
rdesgroppes added a commit that referenced this pull request Mar 4, 2026
### What does this PR do?
Reapply #47007, reverted in #47083 following #incident-50242, but with
the following adjustments:
1. scope repository caches to individual jobs (`$CI_JOB_NAME`) rather
   than runner types (`$CI_RUNNER_DESCRIPTION`),
2. add `.cache/ms-go*` to the cached paths (neutral until `msgo` 1.26+).

### Motivation
#incident-50242 traced to FIPS and non-FIPS omnibus jobs racing to write
incompatible Go build artifacts to the same cache key: `msgo` tags
indeed compile objects with `X:systemcrypto` while upstream Go does not.

It turns out to be a **known issue**: microsoft/go#1994.

Until the corresponding fix is available (microsoft/go#1998), that is
when bumping the Go SDK version to 1.26+, the main adjustment consists
in temporarily scoping repository caches to jobs.
Per-job cache keys naturally segregate the two without requiring an
explicit FIPS discriminator (we couldn't rely on `$FLAVOR` because it's
not expanding consistently across jobs).

### Additional Notes
When switching to Go SDK 1.26+, we'll revert `$CI_RUNNER_DESCRIPTION`
because `msgo` 1.26+ will eliminate the conflict at the toolchain level
thanks to microsoft/go#1998.
rdesgroppes added a commit that referenced this pull request Mar 4, 2026
### What does this PR do?
Reapply #47007, reverted in #47083 following #incident-50242, but with
the following adjustments:
1. scope repository caches to individual jobs (`$CI_JOB_NAME`) rather
   than runner types (`$CI_RUNNER_DESCRIPTION`),
2. add `.cache/ms-go*` to the cached paths (neutral until `msgo` 1.26+).

### Motivation
#incident-50242 traced to FIPS and non-FIPS omnibus jobs racing to write
incompatible Go build artifacts to the same cache key: `msgo` tags
indeed compile objects with `X:systemcrypto` while upstream Go does not.

It turns out to be a **known issue**: microsoft/go#1994.

Until the corresponding fix is available (microsoft/go#1998), that is
when bumping the Go SDK version to 1.26+, the main adjustment consists
in temporarily scoping repository caches to jobs.
Per-job cache keys naturally segregate the two without requiring an
explicit FIPS discriminator (we couldn't rely on `$FLAVOR` because it's
not expanding consistently across jobs).

### Additional Notes
When switching to Go SDK 1.26+, we'll revert `$CI_RUNNER_DESCRIPTION`
because `msgo` 1.26+ will eliminate the conflict at the toolchain level
thanks to microsoft/go#1998.
gh-worker-dd-mergequeue-cf854d bot pushed a commit that referenced this pull request Mar 4, 2026
### What does this PR do?
Reapply #47007, reverted in #47083 following #incident-50242, but with the following adjustments:
1. scope repository caches to individual jobs (`$CI_JOB_NAME`) rather than runner types (`$CI_RUNNER_DESCRIPTION`),
2. add `.cache/ms-go*` to the cached paths (neutral until `msgo` 1.26+).

### Motivation
#incident-50242 traced to FIPS and non-FIPS omnibus jobs racing to write incompatible Go build artifacts to the same cache key: `msgo` tags indeed compile objects with `X:systemcrypto` while upstream Go does not.

It turns out to be a **known issue**: microsoft/go#1994.

Until the corresponding fix (microsoft/go#1998) is available, that is when bumping the Go SDK version to 1.26+, the main adjustment consists in temporarily scoping repository caches to jobs.
Per-job cache keys naturally segregate the two without requiring an explicit FIPS discriminator (we couldn't rely on `$FLAVOR` because it's not expanding consistently across jobs).

### Additional Notes
When switching to Go SDK 1.26+, we'll revert `$CI_RUNNER_DESCRIPTION` because `msgo` 1.26+ will eliminate the conflict at the toolchain level thanks to microsoft/go#1998.

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant