Skip to content

Bump rules_pkg for fixes: rpmbuild errors, symlink deletion#46783

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
regis.desgroppes/bump-rules-pkg
Mar 20, 2026
Merged

Bump rules_pkg for fixes: rpmbuild errors, symlink deletion#46783
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
regis.desgroppes/bump-rules-pkg

Conversation

@rdesgroppes
Copy link
Copy Markdown
Contributor

@rdesgroppes rdesgroppes commented Feb 21, 2026 •
edited
Loading

@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Feb 21, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-build labels Feb 21, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 21, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Feb 22, 2026 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 178cf93
📊 Static Quality Gates Dashboard
🔗 SQG Job

30 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 750.698 MiB
✅ agent_deb_amd64_fips 707.630 MiB
✅ agent_heroku_amd64 313.002 MiB
✅ agent_rpm_amd64 750.682 MiB
✅ agent_rpm_amd64_fips 707.614 MiB
✅ agent_rpm_arm64 729.014 MiB
✅ agent_rpm_arm64_fips 689.006 MiB
✅ agent_suse_amd64 750.682 MiB
✅ agent_suse_amd64_fips 707.614 MiB
✅ agent_suse_arm64 729.014 MiB
✅ agent_suse_arm64_fips 689.006 MiB
✅ docker_agent_amd64 811.017 MiB
✅ docker_agent_arm64 814.163 MiB
✅ docker_agent_jmx_amd64 1001.932 MiB
✅ docker_agent_jmx_arm64 993.857 MiB
✅ docker_cluster_agent_amd64 205.172 MiB
✅ docker_cluster_agent_arm64 219.549 MiB
✅ docker_cws_instrumentation_amd64 7.142 MiB
✅ docker_cws_instrumentation_arm64 6.689 MiB
✅ docker_dogstatsd_amd64 39.215 MiB
✅ docker_dogstatsd_arm64 37.445 MiB
✅ dogstatsd_deb_amd64 29.855 MiB
✅ dogstatsd_deb_arm64 28.007 MiB
✅ dogstatsd_rpm_amd64 29.855 MiB
✅ dogstatsd_suse_amd64 29.855 MiB
✅ iot_agent_deb_amd64 43.218 MiB
✅ iot_agent_deb_arm64 40.273 MiB
✅ iot_agent_deb_armhf 41.017 MiB
✅ iot_agent_rpm_amd64 43.219 MiB
✅ iot_agent_suse_amd64 43.219 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 +21.48 KiB (0.01% increase) 174.672 → 174.693 → 177.700
✅ agent_deb_amd64_fips neutral 165.211 MiB → 172.230
✅ agent_heroku_amd64 neutral 74.945 MiB → 79.970
✅ agent_rpm_amd64 +42.94 KiB (0.02% increase) 177.495 → 177.537 → 180.780
✅ agent_rpm_amd64_fips +18.02 KiB (0.01% increase) 167.261 → 167.279 → 173.370
✅ agent_rpm_arm64 -34.76 KiB (0.02% reduction) 159.590 → 159.556 → 161.610
✅ agent_rpm_arm64_fips -5.08 KiB (0.00% reduction) 151.300 → 151.296 → 155.910
✅ agent_suse_amd64 +42.94 KiB (0.02% increase) 177.495 → 177.537 → 180.780
✅ agent_suse_amd64_fips +18.02 KiB (0.01% increase) 167.261 → 167.279 → 173.370
✅ agent_suse_arm64 -34.76 KiB (0.02% reduction) 159.590 → 159.556 → 161.610
✅ agent_suse_arm64_fips -5.08 KiB (0.00% reduction) 151.300 → 151.296 → 155.910
✅ docker_agent_amd64 neutral 267.882 MiB → 271.240
✅ docker_agent_arm64 neutral 255.084 MiB → 259.800
✅ docker_agent_jmx_amd64 -4.9 KiB (0.00% reduction) 336.530 → 336.525 → 339.870
✅ docker_agent_jmx_arm64 +2.24 KiB (0.00% increase) 319.721 → 319.723 → 324.390
✅ docker_cluster_agent_amd64 neutral 71.886 MiB → 72.920
✅ docker_cluster_agent_arm64 neutral 67.458 MiB → 68.220
✅ docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
✅ docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
✅ docker_dogstatsd_amd64 neutral 15.161 MiB → 15.820
✅ docker_dogstatsd_arm64 neutral 14.480 MiB → 14.830
✅ dogstatsd_deb_amd64 neutral 7.886 MiB → 8.790
✅ dogstatsd_deb_arm64 neutral 6.773 MiB → 7.710
✅ dogstatsd_rpm_amd64 neutral 7.898 MiB → 8.800
✅ dogstatsd_suse_amd64 neutral 7.898 MiB → 8.800
✅ iot_agent_deb_amd64 neutral 11.385 MiB → 12.040
✅ iot_agent_deb_arm64 -2.53 KiB (0.03% reduction) 9.695 → 9.693 → 10.450
✅ iot_agent_deb_armhf neutral 9.929 MiB → 10.620
✅ iot_agent_rpm_amd64 neutral 11.401 MiB → 12.060
✅ iot_agent_suse_amd64 neutral 11.401 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Feb 22, 2026 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4d846940-3b91-4843-8e87-7573834233fa

Baseline: be23386
Comparison: a44953e
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +0.15 [-2.87, +3.18] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ tcp_syslog_to_blackhole ingress throughput +2.55 [+2.40, +2.70] 1 Logs
➖ quality_gate_logs % cpu utilization +1.07 [-0.48, +2.62] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization +1.00 [+0.89, +1.11] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.36 [+0.30, +0.42] 1 Logs
➖ ddot_metrics_sum_delta memory utilization +0.24 [+0.07, +0.41] 1 Logs
➖ docker_containers_cpu % cpu utilization +0.15 [-2.87, +3.18] 1 Logs
➖ quality_gate_idle memory utilization +0.05 [-0.00, +0.10] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency egress throughput +0.02 [-0.47, +0.51] 1 Logs
➖ quality_gate_metrics_logs memory utilization +0.01 [-0.22, +0.25] 1 Logs bounds checks dashboard
➖ file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.42, +0.44] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.19, +0.19] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.11, +0.11] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.20, +0.19] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.02 [-0.05, +0.02] 1 Logs bounds checks dashboard
➖ file_to_blackhole_500ms_latency egress throughput -0.04 [-0.43, +0.36] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.04 [-0.21, +0.12] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.09 [-0.17, -0.00] 1 Logs
➖ ddot_logs memory utilization -0.26 [-0.32, -0.19] 1 Logs
➖ ddot_metrics memory utilization -0.30 [-0.48, -0.12] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.31 [-0.54, -0.09] 1 Logs
➖ file_tree memory utilization -0.66 [-0.71, -0.61] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization -0.69 [-0.83, -0.55] 1 Logs
➖ docker_containers_memory memory utilization -1.24 [-1.38, -1.10] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
✅ docker_containers_cpu simple_check_run 10/10 720 ≥ 26
✅ docker_containers_memory memory_usage 10/10 274.46MiB ≤ 370MiB
✅ docker_containers_memory simple_check_run 10/10 681 ≥ 26
✅ file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
✅ file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_1000ms_latency memory_usage 10/10 0.24GiB ≤ 1.20GiB
✅ file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
✅ file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
✅ file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
✅ quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 174.50MiB ≤ 175MiB bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 2 ≤ 3 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 488.58MiB ≤ 550MiB bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 202.60MiB ≤ 220MiB bounds checks dashboard
✅ quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 340.81 ≤ 2000 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 414.21MiB ≤ 475MiB bounds checks dashboard
✅ quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Mar 9, 2026

This pull request has been automatically marked as stale because it has not had activity in the past 15 days.

It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window.

Thank you for your contributions!

@dd-octo-sts dd-octo-sts bot added the stale label Mar 9, 2026
@rdesgroppes
Bump rules_pkg to fix swallowed rpmbuild exit code
90e46b7 
### What does this PR do?
Bump `rules_pkg` to Feb 21 `main, picking up:
- bazelbuild/rules_pkg#1021
- bazelbuild/rules_pkg#1024
- bazelbuild/rules_pkg#1025

### Motivation
The missing exit code propagation fixed by bazelbuild/rules_pkg#1024 is the main driver of this change because RPM build errors would go unnoticed.
@rdesgroppes
Bump rules_pkg for fixes: rpmbuild, symlink deletion
b9f52a0 
What does this PR do?
bump rules_pkg to Mar 17 main, picking up:
- bazelbuild/rules_pkg#1024: RPM build errors would go unnoticed without it
- bazelbuild/rules_pkg#1035: affects reproducibiliy of builds
- bazelbuild/rules_pkg#1044
- bazelbuild/rules_pkg#1046: a contribution of ours (@chouquette)
- bazelbuild/rules_pkg#1047: we might need this
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-rules-pkg branch from 256632c to b9f52a0 Compare March 20, 2026 07:59
@rdesgroppes rdesgroppes marked this pull request as ready for review March 20, 2026 08:02
@rdesgroppes rdesgroppes requested a review from a team as a code owner March 20, 2026 08:02
@rdesgroppes rdesgroppes changed the title Bump rules_pkg to fix swallowed rpmbuild exit code Bump rules_pkg for fixes: rpmbuild errors, symlink deletion Mar 20, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Mar 20, 2026

Files inventory check summary

File checks results against ancestor ec2fc773:

Results for datadog-agent_7.78.0~devel.git.757.b9f52a0.pipeline.103667368-1_amd64.deb:

No change detected

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit a44953e into main Mar 20, 2026
227 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/bump-rules-pkg branch March 20, 2026 11:15
@github-actions github-actions bot added this to the 7.79.0 milestone Mar 20, 2026
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
@rdesgroppes @StephenWakely
Bump rules_pkg for fixes: rpmbuild errors, symlink deletion (#46783)
83c911a 
### What does this PR do?
Bump `rules_pkg` to current `main`.

### Motivation
Pick up:
- bazelbuild/rules_pkg#1021: a contribution of ours
- bazelbuild/rules_pkg#1024: RPM build errors would go unnoticed without it
- bazelbuild/rules_pkg#1035: affects reproducibiliy of builds
- bazelbuild/rules_pkg#1044
- bazelbuild/rules_pkg#1046: another contribution of ours (@chouquette)
- bazelbuild/rules_pkg#1047: we might need this feature

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
@rdesgroppes @StephenWakely
Bump rules_pkg for fixes: rpmbuild errors, symlink deletion (#46783)
769a32a 
### What does this PR do?
Bump `rules_pkg` to current `main`.

### Motivation
Pick up:
- bazelbuild/rules_pkg#1021: a contribution of ours
- bazelbuild/rules_pkg#1024: RPM build errors would go unnoticed without it
- bazelbuild/rules_pkg#1035: affects reproducibiliy of builds
- bazelbuild/rules_pkg#1044
- bazelbuild/rules_pkg#1046: another contribution of ours (@chouquette)
- bazelbuild/rules_pkg#1047: we might need this feature

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chouquette chouquette chouquette approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly stale team/agent-build

Projects

None yet

Milestone

7.79.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rdesgroppes @chouquette