Support Master Password authentication via env variable#223
Merged
Mikescops merged 1 commit intoDashlane:masterfrom Mar 18, 2024
Merged
Support Master Password authentication via env variable#223Mikescops merged 1 commit intoDashlane:masterfrom
Mikescops merged 1 commit intoDashlane:masterfrom
Conversation
5 tasks
Contributor
|
Hello, |
Contributor
Author
|
The context is short lived and destroyed immediately in my use case as you’ve already seen it in the linked Raycast PR. |
Mikescops
approved these changes
Mar 18, 2024
Contributor
Author
|
@Mikescops |
Contributor
I plan to release on Friday, we have a couple of changes pending this week. |
Mikescops
pushed a commit
that referenced
this pull request
Mar 26, 2024
The original [PR](#223) for this wasn't tested and did not work this PR fixes it, I've tested the changes this time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When spawning
dcliin Node it's impossible to get past master password prompt as stdin doesn't works, this fixes it by checking ifDASHLANE_MASTER_PASSWORDis set when spawning the process.