Add dashTool and dashIdeName query params for DevTools, and change Source=VSCode to Source={dashIdeName} for surveys#6044
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
Updates survey/DevTools attribution to use the host IDE’s actual name (from vs.env.appName) instead of a hard-coded "VSCode", and ensures values are safely URL-encoded when sent via query strings.
Changes:
- Flutter survey URL
Sourcequery parameter now usesvs.env.appNameand encodes query parameters. - DevTools
idequery parameter now usesvs.env.appNameinstead of"VSCode". - Adds a regression test ensuring survey query parameters are URL-encoded.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/shared/vscode/user_prompts.ts | Switches survey Source to vs.env.appName and URL-encodes query params. |
| src/test/dart/user_prompts.test.ts | Adds test coverage for query parameter URL-encoding. |
| src/extension/sdk/dev_tools/manager.ts | Switches DevTools ide query param to vs.env.appName. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6044 +/- ##
==========================================
+ Coverage 70.49% 70.52% +0.02%
==========================================
Files 171 171
Lines 12958 12971 +13
Branches 2590 2589 -1
==========================================
+ Hits 9135 9148 +13
Misses 3336 3336
Partials 487 487 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is no longer used by Pub - see #6044 (comment)
This is no longer used by Pub - see #6044 (comment)
dfbca35 to
1a6d0c4
Compare
1a6d0c4 to
9bb4909
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@kenzieschmoll this PR:
Note: It doesn't change DevTools surveys, because we don't seem to add anything there (these are driven by unified analytics, and I'm not sure if it's tracking the IDEs at all besides the filter?) I think it's safe to land this now if we plan to go ahead as described in flutter/devtools#9811 (comment) (and if so, we'll need to ensure the same is done for IntelliJ - cc @helin24) |
This is no longer used by Pub - see #6044 (comment)
Blocked: pending resolutions to the things in DevTools that switch on the IDE name (see #5970 (comment), flutter/devtools#9811)
Fixes #5970