Pass --coverage-packages to dart test when supported to collect coverage from whole workspace
#5875
Conversation
…overage from whole workspace Fixes #5798
|
@codex review /gemini review |
|
Thank you for invoking It looks like you also included Pull Request Review SummaryThis pull request effectively extends the Key observations:
Overall, the changes are logical, well-structured, and directly address the stated objective of fixing issue #5798. The code is clean and follows good practices for handling feature detection. No further issues were found during this review. |
There was a problem hiding this comment.
Pull request overview
This pull request adds support for passing --coverage-package flags to dart test when the test package version supports it (1.29.0+). This enables collecting coverage from the entire workspace, not just the test file being run, similar to existing Flutter test behavior.
Changes:
- Updated test package version from 1.27.0 to 1.29.0 in test project pubspec files
- Added
supportsCoveragePackagecapability check for dart test package - Modified test launch configuration to compute and pass dart test capabilities for non-Flutter projects
- Enabled previously skipped coverage tests that verify cross-package coverage collection
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/test_projects/hello_world/pubspec.yaml | Updated test package to version 1.29.0 to support --coverage-package flag |
| src/test/test_projects/hello_world/example/pubspec.yaml | Updated test package to version 1.29.0 to support --coverage-package flag |
| src/test/helpers.ts | Reorganized file exports, added helloWorldExampleSubFolderPrinterFile, improved error message |
| src/test/flutter_test_debug/debug/flutter_test.test.ts | Added dartTestCapabilities parameter to getLaunchConfig call (not used for Flutter) |
| src/test/dart_debug/dart_test.test.ts | Re-enabled coverage tests with capability checks, added imports for new test files |
| src/shared/utils/test.ts | Added dartTestCapabilities parameter and logic to conditionally use --coverage-package for Dart tests |
| src/shared/capabilities/dart_test.ts | Added supportsCoveragePackage capability that checks for version 1.29.0+ or --coverage-package flag |
| src/extension/commands/test.ts | Compute and pass dartTestCapabilities for Dart tests, refactored capability checking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5875 +/- ##
==========================================
- Coverage 67.34% 67.00% -0.34%
==========================================
Files 168 168
Lines 12891 12894 +3
Branches 2553 2554 +1
==========================================
- Hits 8681 8640 -41
- Misses 3759 3796 +37
- Partials 451 458 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #5798