Skip to content

Remove trigger characters that often have whitespace after them #1494

@DanTup

Description

@DanTup

There have been many issues relating to trigger characters: #1483, #1406, #1351, #1256, #1254. Most of these stem from us trying to open the completion every time we think it'd be useful for users, however other extensions don't seem to do this and VS Code doesn't support it well in cases where whitespace may appear after a trigger character (microsoft/vscode#66860, microsoft/vscode#69542).

The only good fix I can think of is to remove trigger characters that might come before whitespace (and undo the filterText change).

Current trigger characters and proposed changes:

  • . - used when accessing members - KEEP
  • : - used for named arguments - may be followed by whitespace - REMOVE
  • = - used for assignments/named arg defaults - may be followed by whitespace - REMOVE
  • ( - used for calling members, not usually followed by whitespace - KEEP?
  • $ - used in variable interpolation - not followed by whitespace - KEEP
  • { - used in variable interpolation - may be followed by newlines (blocks) but this is filtered to ${ in the completion handler - KEEP
  • ' - filtered to only imports/exports in completion handler - KEEP
  • " - filtered to only imports/exports in completion handler - KEEP
  • / - filtered to only imports/exports in completion handler - KEEP
  • \ - filtered to only imports/exports in completion handler - KEEP

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions