added firebird support #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added firebird sql adapter to allow record insert and key retrieving
|
Works fine, tested it a bit. You just seem to have forgotten the Async class. |
Author
|
You're more than welcome to create your pull request providing async support too. |
Member
|
that looks pretty awesome; one bit of feedback: when I wrote some very
similar code in the core of dapper, some folks (correctly) noted that the
use of interpolated strings *could* hypothetically be abused on a
compromised server to do very very bad things. Of course by that note: if
you're already compromised you're kinda screwed anyways! I need to do a
review to see how much we are/aren't using interpolated strings generally
to assess whether this is meaningful feedback (it would be silly to
criticize this if we used it extensively every where else in the code)
…On 1 Dec 2016 10:39 a.m., "Phelipe de Sterlich" ***@***.***> wrote:
added firebird sql adapter to allow record insert and key retrieving
------------------------------
You can view, comment on, or merge this pull request online at:
#651
Commit Summary
- added firebird support
File Changes
- *M* Dapper.Contrib/SqlMapperExtensions.cs
<https://github.com/StackExchange/dapper-dot-net/pull/651/files#diff-0>
(33)
Patch Links:
- https://github.com/StackExchange/dapper-dot-net/pull/651.patch
- https://github.com/StackExchange/dapper-dot-net/pull/651.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#651>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AABDsOtYibJeA1lppPsTGFcfDsMSd4BYks5rDqPegaJpZM4LBO-R>
.
|
Member
|
@mgravell It's used in the other adapters, so I'm for taking this as-is. I agree we should clean them all up though. I'll make a note for the v2 push to do so. |
28 tasks
Contributor
|
It seems that FB Async was added in a7ff0b3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added firebird sql adapter to allow record insert and key retrieving