Skip to content

ServerNameAvailability API to validate server names#2

Merged
arde0708 merged 2 commits intodaeunyim/ppbugbashfrom
arde/ppplusone
Sep 30, 2020
Merged

ServerNameAvailability API to validate server names#2
arde0708 merged 2 commits intodaeunyim/ppbugbashfrom
arde/ppplusone

Conversation

@arde0708
Copy link
Copy Markdown
Collaborator

This PR adresses :
-Update MySQL Connection String in create command result.
-Replace server name check with CheckNameAvailability API
○ MySQL
○ PG
-Fix parameter names for point in time

  • Update network Client
  • Include help commands for create with Vnet and public access in mySQL and PG.

@arde0708 arde0708 requested review from DaeunYim and mjain2 September 30, 2020 01:24
c.argument('source_server', options_list=['--source-server'],
help='The name or resource ID of the source server to restore from.')
c.argument('restore_point_in_time', options_list=['--time'],
c.argument('restore_point_in_time', options_list=['--point-in-time'],
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ask was to rename this to --restore-time for restore commands. I have this in my PR, can you remove this here?

@arde0708 arde0708 merged commit f1c1396 into daeunyim/ppbugbash Sep 30, 2020
DaeunYim pushed a commit that referenced this pull request May 21, 2021
…18098)

* IoT Hub track 2 updates and managed identity implementation (#2)

* Updates to use track 2 Hub GA SDK

* Added user-assigned identity functionality

* Added routing endpoint identity

* Add DeviceConnectionStateEvents as a routing source type

* RoutingSource test updates

* SDK version update to 2.0.0

Co-authored-by: Ryan Kelly <rykelly@microsoft.com>

* Test recording updates with 2.0.0 SDK

* Fixes for hyrid profile commands / tests and iot_security tests

* String fixes from code review

Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

* Updated CLIErrors for missing params to use RequiredArgumentMissingError

* Fix CLIError -> ArgumentUsageError

* PR feedback and test updates

* New format for managed identity parameters

Updated params and help

Test recording updates

* Fix wrong parameter in error description

* Removed identity update command

Added support for 
emove --user-assigned to remove all user-assigned identities

Co-authored-by: Ryan Kelly <rykelly@microsoft.com>
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
DaeunYim pushed a commit that referenced this pull request Jul 28, 2021
…file (Azure#18888)

* Add support for bicep files in TS

* Add tests

* re-record test

* Changed new test to a live test

* Changed new test to a live test #2
DaeunYim pushed a commit that referenced this pull request Aug 9, 2023
…zure#23456)

* solutions_reference_data

* Introducing securitySolutionsReferenceData CLI

* Add recording

* fix style check

* Update help

* update test module

* reference_data to reference-data

* update help

* update help #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants