DAC-143: Add unit tests for SoundManager autoload#33
Merged
Conversation
Tests cover: - Instantiation and audio player pool creation - play() early-return guards: DND, sound disabled, zero volume, unknown sound - play_for_message() skips own messages and currently-viewed channel - Signal connections to AppState (message_sent, voice_joined, voice_left, voice_mute_changed, voice_deafen_changed) - Window focus tracking (_window_focused state via _notification) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fcb76d3 to
d441e3c
Compare
krazyjakee
added a commit
that referenced
this pull request
Jun 8, 2026
- #32: audit log gains action-type + user filters, cursor pagination (load-more), and live gateway prepend via onAuditLogCreate - #33: reports queue gains status filter (All/Pending/Actioned/Dismissed), pagination, and inline delete-message/kick/ban actions that also action the report Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/test_sound_manager.gdwith 17 unit tests forSoundManager_ready()play()early-return guards: DND, sound disabled, zero volume, unknown sound nameplay_for_message()skips own messages and currently-viewed channelmessage_sent,voice_joined,voice_left,voice_mute_changed,voice_deafen_changed)_notification(NOTIFICATION_APPLICATION_FOCUS_IN/OUT)Test plan
./test.sh unit)gdlint scripts/ scenes/)