DAC-130: Unit tests for profile management dialogs#26
Merged
Conversation
- test_create_profile_dialog: structure, validation (empty name, too-long name, password mismatch), confirm-field visibility toggle, signal existence - test_profile_password_dialog: structure, setup(), empty-password validation, wrong-password path (via inline stub), signal existence Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
krazyjakee
added a commit
that referenced
this pull request
Jun 8, 2026
Closes #4 and #26. New ReadStateController (keepAlive) tracks per-channel unread + mention counts, mirroring the reference client's client_unread.gd: the gateway handler marks a channel unread on every MESSAGE_CREATE that isn't in the currently-visible channel (bumping the mention count when the user is mentioned), and selecting a channel marks it read locally + POSTs channels.ack with the latest message ID so the server's read position catches up. _ChannelTile renders the channel name bold with a white dot when unread, or a red mention pill with the count. _SpaceIcon overlays the same indicators on the rail (a left-rail unread pip or a corner mention pill), rolling up read state across all loaded channels of the space. State is in-memory only, matching the reference's behavior on cold start. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_create_profile_dialog.gd: covers UI structure, empty-name validation, too-long-name validation, password mismatch validation, confirm-field visibility toggle, andprofile_createdsignal existencetest_profile_password_dialog.gd: covers UI structure,setup(), empty-password validation, wrong-password path (using an inline_StubProfilesRejectstub to forceverify_passwordto returnfalse), andpassword_verifiedsignal existenceTest plan
./test.sh unit)gdlint scripts/ scenes/)