Skip to content

[hotfix-#1304][binlog]1.Use version 19 of guava 2. Introduce protobuf… #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FlechazoW merged 1 commit into from
Oct 13, 2022
Merged

[hotfix-#1304][binlog]1.Use version 19 of guava 2. Introduce protobuf… #1305

FlechazoW merged 1 commit into from
Oct 13, 2022

Conversation

@qumaosihaozi
Copy link
Contributor

@qumaosihaozi qumaosihaozi commented Oct 13, 2022 •
edited
Loading

…-java dependencies 3.Added shade relocation for binlog's guava and protobuf

Purpose of this pull request

1.Use version 19 of guava 2. Introduce protobuf-java dependencies 3.Added shade relocation for binlog's guava and protobuf

Which issue you fix

Fixes # (issue).
#1304

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@Paddy0523 Paddy0523 added the bug Something isn't working label Oct 13, 2022
@Paddy0523 Paddy0523 linked an issue Oct 13, 2022 that may be closed by this pull request
[Bug] [Binlog] protobuf dependency loss and guava dependency conflict #1304
Closed
3 tasks
@qumaosihaozi
[hotfix-DTStack#1304][binlog]1.Use version 19 of guava 2. Introduce p…
d00086f 
…rotobuf-java dependencies 3.Added shade relocation for binlog's guava and protobuf
@Paddy0523
Copy link
Contributor

Paddy0523 commented Oct 13, 2022

LGTM
@FlechazoW

@FlechazoW FlechazoW merged commit 4881c4d into DTStack:master Oct 13, 2022
lyzeo pushed a commit to lyzeo/chunjun that referenced this pull request Oct 19, 2022
@qumaosihaozi
[hotfix-DTStack#1304][binlog] Adjust binlog dependency. (DTStack#1305)
6167aae 
1.Use version 19 of guava;
2. Introduce protobuf-java dependencies;
3.Added shade relocation for binlog's guava and protobuf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [Binlog] protobuf dependency loss and guava dependency conflict

3 participants

@qumaosihaozi @Paddy0523 @FlechazoW