Merged
Conversation
Initial implementation of Storybook with one component (dnn-button)
Implement storybook and auto include Stencil docs
This adds a complete story for dnn-collapsible including actions hooks and supported properties. Also this brings in lit-html which is not LitElements, it is only a very small independent par of it that allows almost jsx support which allows to dynamically create html from custom elements. Under the hood it creates an html template and keeps a reference to all dynamic parts, then injects a clone of that component with the dynamic parts replaced each time the function get's called. Soooo, I initially though that the WebComponents docs where made only for LitElements but in fact it just used one independed function from them. See https://lit.dev/docs/v1/lit-html/introduction/ for some intro and https://lit.dev/docs/v1/lit-html/template-reference/ for some more details on the binding types. Basically `?` prefix for bolean attributes, `.` prefix for properties that are not attributes and `@` prefix for event listeners. We may just need `?` in our use cases though. There is also a vscode extension called lit-html which does syntax highlighting almost like in jsx/tsx. One more note, I am not totally set on the idea, so we can chat about it, but if the last part of the path matches exactly the only named export (there is a single story), then the component in the list is hoisted up one level so it saves the user to have to expand that level on the left list. But apparently it needs to be a single word, soooo, we can play with variations maybe there is some science to this auto-magic.
Adds accessibility validation in storybook
Added accessibility validation in storybook
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.17.5 to 7.17.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.17.7/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 2.13.0 to 2.14.2. - [Release notes](https://github.com/ionic-team/stencil/releases) - [Changelog](https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md) - [Commits](stenciljs/core@v2.13.0...v2.14.2) --- updated-dependencies: - dependency-name: "@stencil/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lit-html](https://github.com/lit/lit/tree/HEAD/packages/lit-html) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/lit/lit/releases) - [Changelog](https://github.com/lit/lit/blob/main/packages/lit-html/CHANGELOG.md) - [Commits](https://github.com/lit/lit/commits/lit-html@2.2.1/packages/lit-html) --- updated-dependencies: - dependency-name: lit-html dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 13.4.1 to 13.5.1. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](puppeteer/puppeteer@v13.4.1...v13.5.1) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.29.3 to 7.29.4. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.29.3...v7.29.4) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
## Breaking change Unfortunatelly the checkbox component had a flaw. There was no way to set the intermediate state upon load as the `checked` property was implemented as a nullable boolean. However in html, boolean properties are set either by the present or absense of an attribute and not by the actual attribute value. For that reason the checked property had to be changed to a string with 3 possible values which is a breaking change for dnn-checkbox consumers. This is still a work in progress here is what is done and what is left to do. - [x] implement the logic to handle permissions objects - [x] implement role group and role picker - [x] basic role grid functionality - [ ] add users level permissions support - [ ] implement mobile support (responsiveness)
`npm run storybook.watch` will run stencil with --watch and also open up the storybook live-server which allows developing the components directly while previewing in storybook.
…el/core-7.17.7 Bump @babel/core from 7.17.5 to 7.17.7
…ncil/core-2.14.2 Bump @stencil/core from 2.13.0 to 2.14.2
…-html-2.2.1 Bump lit-html from 2.2.0 to 2.2.1
…int-plugin-react-7.29.4 Bump eslint-plugin-react from 7.29.3 to 7.29.4
…peteer-13.5.1 Bump puppeteer from 13.4.1 to 13.5.1
…tures Storybook theme and features
A big tanks to @david-poindexter and @mtrutledge for helping resolve this one!
Fixed an issue where storybook would get into an infinite loop
…enu-story Add story for `dnn-vertical-overflow-menu` and resolve CSS var issue in component
This allows consumers better control over the inner tab content and then can provide their own padding in the slotted content.
Removed inner padding from dnn-tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Released v0.15.0