Add story for dnn-vertical-overflow-menu and resolve CSS var issue in component#536
Merged
david-poindexter merged 3 commits intoDNNCommunity:developfrom Mar 20, 2022
Conversation
Member
|
Ok, it was hard to put into a review, but here is a PR of what I was thinking to do: |
Contributor
Author
|
That PR has been merged - thank you @valadas - I agree 100% with your proposed changes. As soon as this one builds, it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #517
It appears there is an issue with the SCSS for
--text-colorand the height for the overflow menu when visible, but we can circle back to these later.