Adjusts component and story to style slotted contents externally#1
Merged
david-poindexter merged 1 commit intodavid-poindexter:dnn-vertical-overflow-menu-storyfrom Mar 20, 2022
Conversation
Author
Author
|
Oh, it also fixes a height calculation issues, it was counting the gaps but not the margin around the list... |
david-poindexter
approved these changes
Mar 20, 2022
Owner
david-poindexter
left a comment
There was a problem hiding this comment.
Agreed 100% - thanks @valadas
🌮🎉
48b0f74
into
david-poindexter:dnn-vertical-overflow-menu-story
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Ok, so the idea is that any item in the component can be a button, a link or anything, for instance another custom element. For that reason we do not want to style those items ourselves inside the component as the external styles do apply to slotted elements. This PR adjusts a couple of things: