Fixed an issue that made dnn-input label cover 0#1212
Merged
valadas merged 1 commit intoDNNCommunity:developfrom Oct 25, 2024
Merged
Fixed an issue that made dnn-input label cover 0#1212valadas merged 1 commit intoDNNCommunity:developfrom
valadas merged 1 commit intoDNNCommunity:developfrom
Conversation
valadas
added a commit
to valadas/dnn-elements
that referenced
this pull request
Oct 26, 2024
What was corrected in DNNCommunity#1212 only handled the input being of type "number" but having the string "0" also caused the label issue. This PR fixes that.
valadas
added a commit
to valadas/dnn-elements
that referenced
this pull request
Oct 26, 2024
Another followup on DNNCommunity#1212
valadas
added a commit
to valadas/dnn-elements
that referenced
this pull request
Oct 26, 2024
Still about DNNCommunity#1212 one edge case is the number technically being a "Number" but it's value being NaN instead of undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1201