Better support for armhf devices running Android 8.0+#1064
Merged
Conversation
corbinlc
added a commit
that referenced
this pull request
Oct 16, 2019
Better support for armhf devices running Android 8.0+ (#1064)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes does this PR introduce?
Fix more armhf devices running Android 8.0+
Any background context you want to provide?
Seccomp filtering is from the devil
Where should the reviewer start?
The real changes are to proot
Has this been manually tested? How?
On my devices (unaffected devices) things look the same and for at least one user who was broken things now look fixed.
What value does this provide to our end users?
They can actually use our app
What GIF best describes this PR or how it makes you feel?