feat: collect evidences for license by Frozen-byte · Pull Request #1309 · CycloneDX/cyclonedx-webpack-plugin

Frozen-byte · 2024-10-02T22:55:36Z

fixes #676

… notices Refs: CycloneDX#676 Signed-off-by: frozen_byte <frozen_byte@gmx.de>

…ence` Signed-off-by: frozen_byte <frozen_byte@gmx.de>

package.json

src/_helpers.ts

src/extractor.ts

src/plugin.ts

src/_helpers.ts

…ct passed down as an argument Signed-off-by: frozen_byte <frozen_byte@gmx.de>

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

src/_helpers.ts

src/extractor.ts

src/_helpers.ts

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

src/_helpers.ts

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

…t used once Signed-off-by: frozen_byte <frozen_byte@gmx.de>

src/_helpers.ts

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

…s scope Signed-off-by: frozen_byte <frozen_byte@gmx.de>

… file Signed-off-by: frozen_byte <frozen_byte@gmx.de>

…apshot Signed-off-by: frozen_byte <frozen_byte@gmx.de>

jkowalleck

for tests, do not enable the new feature in all tests beds.
instead, create a new test bed dedicated to the feature, and enable the feature there.

Frozen-byte · 2024-10-07T09:56:37Z

for tests, do not enable the new feature in all tests beds. instead, create a new test bed dedicated to the feature, and enable the feature there.

I copied the folder from exampleWebpack5Angular17 to feature-issue676.
After that, I updated it to angular18 and enabled the evidence option and ran the tests with updating the snapshot.

This error worries me when I execute setup-test:
➤ YN0002: │ @cyclonedx-webpack-plugin-tests/regression-issue1284-yarn@workspace:. Doesn't provide @popperjs/core (pb1d91), requested by bootstrap.
I do not think it is caused by these changes and might be a local problem?
Haven't investigated further, but just FYI.

Frozen-byte · 2024-10-07T10:04:04Z

In addition, my revert commit 3fdd595fe4e9469e8083bcbc888b0084488c455b was not signed off somehow.

Should I leave it? Or renaming this commit one and force pushing a new history? Or will this break things even further?

tests/integration/feature-issue676/README.md

jkowalleck · 2024-10-07T13:47:23Z

In addition, my revert commit 3fdd595fe4e9469e8083bcbc888b0084488c455b was not signed off somehow.

Should I leave it? Or renaming this commit one and force pushing a new history? Or will this break things even further?

We need every commit signed-off. Here are instructions how this can be done via rebase/force-push:
https://github.com/CycloneDX/cyclonedx-webpack-plugin/pull/1309/checks?check_run_id=31165850595

Since you are the only person working on this branch, i don't see any risks. Go ahead :D

…pdate snapshot" This reverts commit 9b7b253. Signed-off-by: frozen_byte <frozen_byte@gmx.de>

…nce feature got moved Signed-off-by: frozen_byte <frozen_byte@gmx.de>

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

…tion test Signed-off-by: frozen_byte <frozen_byte@gmx.de>

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

jkowalleck · 2024-10-07T15:59:42Z

for tests, do not enable the new feature in all tests beds. instead, create a new test bed dedicated to the feature, and enable the feature there.

I copied the folder from exampleWebpack5Angular17 to feature-issue676. After that, I updated it to angular18 and enabled the evidence option and ran the tests with updating the snapshot.

This error worries me when I execute setup-test: ➤ YN0002: │ @cyclonedx-webpack-plugin-tests/regression-issue1284-yarn@workspace:. Doesn't provide @popperjs/core (pb1d91), requested by bootstrap. I do not think it is caused by these changes and might be a local problem? Haven't investigated further, but just FYI.

Either yarn takes care of the missing (peer)dependency, or we just dont care.
Anyway, this is probably no show stopper.

tests/integration/setup.js

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

tests/integration/feature-issue676/webpack-build.config.js

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

jkowalleck · 2024-10-07T16:49:04Z

@Frozen-byte thank you for the contribution. 🚀

I will merge it, and might add some small polishing.

PS: polishing via #1312

followup of #1309 - fixed some false-positives for license evidences. - refactored some functionality, so that it is much easier to add #1310 later Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

feat(EvidenceCollection): collect evidences for licence and copyright…

ac8c142

… notices Refs: CycloneDX#676 Signed-off-by: frozen_byte <frozen_byte@gmx.de>

Frozen-byte requested a review from a team as a code owner October 2, 2024 22:55

chore(EvidenceCollection): sync readme parameters adding `collectEvid…

5bf84dc

…ence` Signed-off-by: frozen_byte <frozen_byte@gmx.de>

jkowalleck requested changes Oct 3, 2024

View reviewed changes

Frozen-byte added 2 commits October 3, 2024 22:09

fix(EvidenceCollection): refactor collectEvidence into an option obje…

30d5de9

…ct passed down as an argument Signed-off-by: frozen_byte <frozen_byte@gmx.de>

fix(EvidenceCollection): revert breaking change of node18

9906cbf

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

jkowalleck added the enhancement New feature or request label Oct 3, 2024

Frozen-byte added 2 commits October 3, 2024 23:29

fix(EvidenceCollection): remove copyright collection feature

107d2b7

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

fix(EvidenceCollection): remove spec check for evidence feature

f32c1c7

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

jkowalleck requested changes Oct 3, 2024

View reviewed changes

Frozen-byte added 4 commits October 4, 2024 13:21

chore(EvidenceCollection): refactor to yielding

7dd053c

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

fix(EvidenceCollection): use named licenses for evidence

6711ad2

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

chore(EvidenceCollection): uppercase the case-insensitive regex

4d33603

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

chore(EvidenceCollection): use single switch instead of option obj

abe3bc3

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

Frozen-byte mentioned this pull request Oct 4, 2024

FEAT: Option to add copyright to SBOM result #1310

Open

Frozen-byte requested a review from jkowalleck October 4, 2024 11:51

jkowalleck requested changes Oct 4, 2024

View reviewed changes

Frozen-byte added 2 commits October 4, 2024 15:01

chore(EvidenceCollection): keep related code together

1336a1b

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

chore(EvidenceCollection): avoid explicit variable names that are jus…

1976436

…t used once Signed-off-by: frozen_byte <frozen_byte@gmx.de>

jkowalleck requested changes Oct 4, 2024

View reviewed changes

src/_helpers.ts Outdated Show resolved Hide resolved

src/_helpers.ts Show resolved Hide resolved

src/_helpers.ts Outdated Show resolved Hide resolved

jkowalleck reviewed Oct 4, 2024

View reviewed changes

src/_helpers.ts Outdated Show resolved Hide resolved

Frozen-byte added 5 commits October 4, 2024 23:45

chore(EvidenceCollection): code-style

895b1c2

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

fix(EvidenceCollection): rm unused argument

1e84884

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

chore(EvidenceCollection): refactor getComponentEvidence to extractor…

1293b13

…s scope Signed-off-by: frozen_byte <frozen_byte@gmx.de>

fix(EvidenceCollection): as missing slash when concatenating path and…

873006b

… file Signed-off-by: frozen_byte <frozen_byte@gmx.de>

chore(Testing): enable collectEvidence option for tests and update sn…

9b7b253

…apshot Signed-off-by: frozen_byte <frozen_byte@gmx.de>

jkowalleck requested changes Oct 5, 2024

View reviewed changes

jkowalleck changed the title ~~feat(EvidenceCollection): collect evidences for licence and copyright notices~~ feat: collect evidences for license Oct 5, 2024

jkowalleck requested changes Oct 7, 2024

View reviewed changes

tests/integration/feature-issue676/README.md Show resolved Hide resolved

Frozen-byte added 5 commits October 7, 2024 17:38

Revert "chore(Testing): enable collectEvidence option for tests and u…

e2e44b0

…pdate snapshot" This reverts commit 9b7b253. Signed-off-by: frozen_byte <frozen_byte@gmx.de>

fix(EvidenceCollection): remove copyright collection documentation si…

9e41244

…nce feature got moved Signed-off-by: frozen_byte <frozen_byte@gmx.de>

feat(Tests): enable collectEvidence option for tests and update snapshot

d4fd58f

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

chore(docs): was created by v18

bf5b1d8

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

fix(Tests): add dummy notice and licence file for the evidence collec…

b652ae0

…tion test Signed-off-by: frozen_byte <frozen_byte@gmx.de>

Frozen-byte force-pushed the master branch from c0df0d7 to b652ae0 Compare October 7, 2024 15:39

fix(Tests): update snapshots with expected license files

f9dede8

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

jkowalleck reviewed Oct 7, 2024

View reviewed changes

tests/integration/setup.js Outdated Show resolved Hide resolved

tests: fix setup of new testbed

796a513

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

jkowalleck requested changes Oct 7, 2024

View reviewed changes

tests/integration/feature-issue676/webpack-build.config.js Show resolved Hide resolved

Frozen-byte and others added 4 commits October 7, 2024 18:23

fix(Tests): update snapshots with new timestamps

03b0346

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

fix(Tests): use reproducibleResults in tests to keep snapshot in sync

b0a5c89

Signed-off-by: frozen_byte <frozen_byte@gmx.de>

Update HISTORY.md

1f987ac

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

Merge branch 'master' into master

7faf23e

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

jkowalleck merged commit 77df409 into CycloneDX:master Oct 7, 2024

jkowalleck mentioned this pull request Oct 7, 2024

fix: pollish evidence gathering #1312

Merged

This was referenced Oct 8, 2024

FEAT: Option to add license text to SBOM result CycloneDX/cyclonedx-node-npm#256

Closed

feat: Add complete License-Text to SBOM result CycloneDX/cyclonedx-node-yarn#33

Closed

jkowalleck mentioned this pull request Dec 9, 2024

feat: add switch to add license text to BOM result CycloneDX/cyclonedx-node-npm#427

Closed

Uh oh!

Conversation

Frozen-byte commented Oct 2, 2024 • edited by jkowalleck Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkowalleck left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Frozen-byte commented Oct 7, 2024

Uh oh!

Frozen-byte commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jkowalleck commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkowalleck commented Oct 7, 2024

Uh oh!

Uh oh!

Uh oh!

jkowalleck commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Frozen-byte commented Oct 2, 2024 •

edited by jkowalleck

Loading

jkowalleck left a comment •

edited

Loading

Frozen-byte commented Oct 7, 2024 •

edited

Loading

jkowalleck commented Oct 7, 2024 •

edited

Loading

jkowalleck commented Oct 7, 2024 •

edited

Loading