Skip to content

Feat/base validator store version#591

Merged
jkowalleck merged 6 commits intofeat/4.0.0-devfrom
feat/BaseValidator-store-version
Jan 9, 2026
Merged

Feat/base validator store version#591
jkowalleck merged 6 commits intofeat/4.0.0-devfrom
feat/BaseValidator-store-version

Conversation

@jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jan 9, 2026

Description

  • CycloneDX\Core\Validation\BaseValidator::__construct() parameter is type CycloneDX\Core\Spec\Version
    Was internal type CycloneDX\Core\Spec\_SpecProtocol.

Resolves or fixes issue: #590

AI Tool Disclosure

  • My contribution does not include any AI-generated content
  • My contribution includes AI-generated content, as disclosed below:
    • AI Tools: [e.g. GitHub CoPilot, ChatGPT, JetBrains Junie etc.]
    • LLMs and versions: [e.g. GPT-4.1, Claude Haiku 4.5, Gemini 2.5 Pro etc.]
    • Prompts: [Summarize the key prompts or instructions given to the AI tools]

Affirmation

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from a team as a code owner January 9, 2026 12:07
@jkowalleck jkowalleck linked an issue Jan 9, 2026 that may be closed by this pull request
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the base branch from master to feat/4.0.0-dev January 9, 2026 12:29
@jkowalleck jkowalleck added this to the v4 milestone Jan 9, 2026
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2f7c8e7) 5535 5513 99.60%
Head commit (cae3f04) 5529 (-6) 5507 (-6) 99.60% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#591) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@jkowalleck jkowalleck merged commit 86b0864 into feat/4.0.0-dev Jan 9, 2026
46 checks passed
@jkowalleck jkowalleck deleted the feat/BaseValidator-store-version branch January 9, 2026 12:54
@jkowalleck jkowalleck mentioned this pull request Jan 9, 2026
jkowalleck added a commit that referenced this pull request Feb 17, 2026
see https://github.com/CycloneDX/cyclonedx-php-library/milestone/4

----


* BREAKING changes
  * Removed deprecated symbols
* Changed constructor of
`CycloneDX\Contrib\License\Factories\LicenseFactory`
  * Changed dependencies
* Removed
  * Class `CycloneDX\Core\Factories\LicenseFactory`  
    Use `CycloneDX\Contrib\License\Factories\LicenseFactory` instead.
  * Class `CycloneDX\Core\Utils\BomUtility`   
    Use `CycloneDX\Contrib\Bom\Utils\BomUtils` instead.
  * Method `CycloneDX\Core\Validation\BaseValidator::getSpec()`  
* Changed
* `CycloneDX\Contrib\License\Factories\LicenseFactory::__construct()`
parameters are no longer autopopulated
Downstream implementations have to populate the parameters on their own,
now.
* `CycloneDX\Core\Models\Component::setPackageUrl()` accepts `?string`
Downstream implementations may use
[package-url/packageurl-php](https://packagist.org/packages/package-url/packageurl-php)
for generation.
* `CycloneDX\Core\Models\Component::getPackageUrl()` returns `?string`
Downstream implementations may use
[package-url/packageurl-php](https://packagist.org/packages/package-url/packageurl-php)
for parsing.
* `CycloneDX\Core\Validation\BaseValidator::__construct()` parameter is
type `CycloneDX\Core\Spec\Version`
    Was internal type `CycloneDX\Core\Spec\_SpecProtocol`.
* Dependencies
  * No longer depends on, but suggests `composer/spdx-licenses:^1.5` 
May be used when utilizing
`CycloneDX\Contrib\License\Factories\LicenseFactory`.
  * No longer depend on `package-url/packageurl-php`  
 
----

- contains #587 
- contains #588 
- contains #591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix todos for next major version

1 participant