feat: Add license text as evidence#1243
Conversation
Signed-off-by: Matthias Schiebel <msl@compart.com> Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Matthias Schiebel <msl@compart.com> Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <christoph.uhland@bdr.de> Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
address design principles and architecture of this project. Still wip Signed-off-by: Christoph Uhland <christoph.uhland@bdr.de> Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
As suggested in CycloneDX#427 (comment) Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
jkowalleck
left a comment
There was a problem hiding this comment.
Thank you for all of your efforts, @cuhland .
some changes/refactors are needed, please see my remarks below.
Also, please add the appropriate test-beds. I could expect this can be trickt. let me know if you need help with this.
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
d723f0a to
282c81c
Compare
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
|
some code styles are not applied as expected. see https://github.com/CycloneDX/cyclonedx-node-npm/actions/runs/12370296220/job/34526888496?pr=1243 |
Signed-off-by: Christoph Uhland <42832096+cuhland@users.noreply.github.com>
|
@cuhland , i will merge the feature soon, so it will be part of the next release. next release is planned for January 2025. |
Thanks. |
|
@cuhland and @jkowalleck - Thanks for integrating the --gather-license-texts option. |
followup of #1243 make implementation a copy-past of existing art: <https://github.com/CycloneDX/cyclonedx-node-yarn/blob/main/src/_helpers.ts> this should make it easier for CycloneDX/cyclonedx-javascript-library#1162 --------- Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
|
this feature was released via v1.20.0 |
fixes #256
This PR is based on #427, and uses the same implementation as it was implemented in yarn (See CycloneDX/cyclonedx-node-yarn#193)
closes #427