Skip to content

docs(examples): use generic packageurls#886

Merged
jkowalleck merged 1 commit intomainfrom
docs-purlFactory-use-generic
Jul 3, 2023
Merged

docs(examples): use generic packageurls#886
jkowalleck merged 1 commit intomainfrom
docs-purlFactory-use-generic

Conversation

@jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jul 3, 2023

used generic PURLS, to make examples more ... generic,
and to circumvent confusion with FromNodePackageJson.PackageUrlFactory

@jkowalleck jkowalleck added the documentation Improvements or additions to documentation label Jul 3, 2023
@jkowalleck jkowalleck requested a review from a team as a code owner July 3, 2023 11:21
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the docs-purlFactory-use-generic branch from 3b3bb4e to ab5f23b Compare July 3, 2023 11:22
@jkowalleck jkowalleck merged commit 81db6c1 into main Jul 3, 2023
@jkowalleck jkowalleck deleted the docs-purlFactory-use-generic branch July 3, 2023 11:29
@codacy-production
Copy link

Coverage summary from Codacy

Merging #886 (ab5f23b) into main (fe9b717) - See PR on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fe9b717) 6993 6872 98.27%
Head commit (ab5f23b) 6993 (+0) 6872 (+0) 98.27% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#886) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant