BC: Properly exclude external packages when preparing this library for web browsers#880
Merged
jkowalleck merged 5 commits intomainfrom Jul 2, 2023
Merged
BC: Properly exclude external packages when preparing this library for web browsers#880jkowalleck merged 5 commits intomainfrom
jkowalleck merged 5 commits intomainfrom
Conversation
53e8179 to
d73513a
Compare
Coverage summary from CodacyMerging #880 (f83a788) into
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
7600458 to
09e264e
Compare
…r web browsers Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
* example parcel Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * example parcel Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> --------- Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
05cb8e7 to
95cce97
Compare
270c22a to
9d6163a
Compare
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
9d6163a to
f83a788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #883
In fact, this fixes the non-working
LicenseFactoryandPackageUrlFactory.Both were unable to load external packages/structs (
spdx-expression-parser,PackageURL) and therefore worked incorrectle, without any warning.This behavior was changed, now the library will crash in browsers, if the externals are not fetched properly.
after the fix, the license is SPDX expression, and the purl is present
{"$schema":"http://cyclonedx.org/schema/bom-1.5.schema.json","bomFormat":"CycloneDX","specVersion":"1.5","version":1,"metadata":{"component":{"type":"application","name":"MyProject","bom-ref":"BomRef.3lr3il32iug.rtg99q9kgg","licenses":[{"expression":"MIT OR Apache-2.0"}]}},"components":[{"type":"library","name":"myComponentA","group":"acme","version":"1.33.7","bom-ref":"BomRef.b15pj468j14.scmk07ernt","licenses":[{"license":{"id":"Apache-2.0"}}],"purl":"pkg:npm/acme/myComponentA@1.33.7?"}],"dependencies":[{"ref":"BomRef.3lr3il32iug.rtg99q9kgg","dependsOn":["BomRef.b15pj468j14.scmk07ernt"]},{"ref":"BomRef.b15pj468j14.scmk07ernt"}]}