Skip to content

Package json split name group unorthodox names#600

Merged
jkowalleck merged 3 commits intomainfrom
packageJson-splitNameGroup-unorthodoxNames
Mar 29, 2023
Merged

Package json split name group unorthodox names#600
jkowalleck merged 3 commits intomainfrom
packageJson-splitNameGroup-unorthodoxNames

Conversation

@jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Mar 29, 2023

fixes #599

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the bug Something isn't working label Mar 29, 2023
@jkowalleck jkowalleck requested a review from a team as a code owner March 29, 2023 14:23
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@codacy-production
Copy link

Coverage summary from Codacy

Merging #600 (d6e092c) into main (b99f6de) - See PR on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b99f6de) 5274 5177 98.16%
Head commit (d6e092c) 5280 (+6) 5183 (+6) 98.16% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#600) 9 9 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@jkowalleck jkowalleck merged commit 7cf5337 into main Mar 29, 2023
@jkowalleck jkowalleck deleted the packageJson-splitNameGroup-unorthodoxNames branch March 29, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Builders.FromNodePackageJson.ComponentBuilder cuts names after second slash

1 participant