Skip to content

fix: properly handle XML normalizedString/token#1116

Merged
jkowalleck merged 17 commits intomainfrom
fix/xml_normalizedString_token
Jul 3, 2024
Merged

fix: properly handle XML normalizedString/token#1116
jkowalleck merged 17 commits intomainfrom
fix/xml_normalizedString_token

Conversation

@jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jul 3, 2024 •
edited
Loading

fixes #1098

@jkowalleck
impl & basic tests
961218c 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the bug Something isn't working label Jul 3, 2024
@jkowalleck jkowalleck requested a review from a team as a code owner July 3, 2024 08:29
@jkowalleck jkowalleck marked this pull request as draft July 3, 2024 08:29
@jkowalleck jkowalleck changed the title fix: XML normalizedString [wip] fix: XML normalizedString Jul 3, 2024
jkowalleck added 2 commits July 3, 2024 10:30
@jkowalleck
tests
f882aae 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
impl
d21d266 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the fix/xml_normalizedString_token branch from 3e58ae1 to d21d266 Compare July 3, 2024 10:06
@codacy-production
Copy link

codacy-production bot commented Jul 3, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.02% (target: -1.00%) ✅ 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b209685) 23310 22912 98.29%
Head commit (38449e6) 23562 (+252) 23164 (+252) 98.31% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1116) 117 117 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

jkowalleck added 8 commits July 3, 2024 12:16
@jkowalleck
impl
bf6be2d 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
impl
d4a64aa 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
style
8663835 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
docs
840d527 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
impl
bde5755 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
impl
163be02 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
refactor
8f0bbf4 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
tests
8d71be1 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title [wip] fix: XML normalizedString fix: XML normalizedString Jul 3, 2024
@jkowalleck jkowalleck changed the title fix: XML normalizedString fix: XML normalizedString and token Jul 3, 2024
@jkowalleck jkowalleck marked this pull request as ready for review July 3, 2024 11:27
@jkowalleck jkowalleck changed the title fix: XML normalizedString and token fix: properly handle XML normalizedString/token Jul 3, 2024
jkowalleck added 6 commits July 3, 2024 13:48
@jkowalleck
tests
1d12e76 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
tests
0187797 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
style
e6ee833 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
dings
2d76d6c 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
dings
265ded2 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
docs
38449e6 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit 5f76549 into main Jul 3, 2024
@jkowalleck jkowalleck deleted the fix/xml_normalizedString_token branch July 3, 2024 13:12
@jkowalleck jkowalleck mentioned this pull request Jul 3, 2024
Closed
This was referenced Jul 3, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[XML] properly handle normalizedString & token

1 participant

@jkowalleck