Skip to content

fix: PackageUrlFactory generic default#1076

Merged
jkowalleck merged 3 commits intomainfrom
fix/PackageUrlFactory-Generic-default
May 21, 2024
Merged

fix: PackageUrlFactory generic default#1076
jkowalleck merged 3 commits intomainfrom
fix/PackageUrlFactory-Generic-default

Conversation

@jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented May 21, 2024

Fixed

  • Added Factories.PackageUrlFactory's generic type's default back in

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the bug Something isn't working label May 21, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review May 21, 2024 16:41
@jkowalleck jkowalleck requested a review from a team as a code owner May 21, 2024 16:41
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for f45a49a1 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f45a49a) Report Missing Report Missing Report Missing
Head commit (baf0955) 22917 22506 98.21%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1076) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jkowalleck jkowalleck merged commit f9191e1 into main May 21, 2024
@jkowalleck jkowalleck deleted the fix/PackageUrlFactory-Generic-default branch May 21, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant