Skip to content

feat: license acknowledgement#1052

Merged
jkowalleck merged 18 commits intomainfrom
feat/license-acknowledgement
Apr 26, 2024
Merged

feat: license acknowledgement#1052
jkowalleck merged 18 commits intomainfrom
feat/license-acknowledgement

Conversation

@jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Apr 24, 2024

fixes #1051

Changed

  • Serializers and License-Normalizers will take license acknowledgement into account (#1051 via #1052)

Added:

  • Namespace Enums
    • New enum LicenseAcknowledgement (#1051 via #1052)
  • Namespace Models
    • Class LicenseExpression got new property acknowledgement (#1051 via #1052)
    • Class NamedLicense got new property acknowledgement (#1051 via #1052)
    • Class SpdxLicense got new property acknowledgement (#1051 via #1052)

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added enhancement New feature or request schema 1.6 related to CycloneDX spec v1.6 labels Apr 24, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@codacy-production
Copy link

codacy-production bot commented Apr 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3bb5cc7) 22569 22158 98.18%
Head commit (21916a4) 22776 (+207) 22365 (+207) 98.20% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1052) 77 77 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@jkowalleck jkowalleck marked this pull request as ready for review April 26, 2024 12:19
@jkowalleck jkowalleck requested a review from a team as a code owner April 26, 2024 12:19
@jkowalleck jkowalleck marked this pull request as draft April 26, 2024 12:20
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review April 26, 2024 14:00
@jkowalleck jkowalleck changed the title [WIP] feat: license acknowledgement feat: license acknowledgement Apr 26, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit 5da05d2 into main Apr 26, 2024
@jkowalleck jkowalleck deleted the feat/license-acknowledgement branch April 26, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request schema 1.6 related to CycloneDX spec v1.6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support license.acknowledgment

1 participant