fix: make rename() subdir check UTF-8 safe#295
Merged
lzjqsdd merged 1 commit intoCurvineIO:mainfrom Sep 22, 2025
Merged
Conversation
Contributor
|
The error has occurred when you test Curvine cache or it happened in other system that you had met？ |
lzjqsdd
approved these changes
Sep 22, 2025
Coderlxl
pushed a commit
to Coderlxl/curvine
that referenced
this pull request
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the path contains multi char characters(such as
/a/b/äå), The comparison&dst[src.len()..src.len() + 1] == PATH_SEPARATORis not safe, we could meet the error likebyte index 1 is not a char boundary.Also fix some typo issues from the file