feat: add comprehensive credential management system for S3 Gateway#248
Merged
szbr9486 merged 1 commit intoCurvineIO:mainfrom Sep 11, 2025
Merged
feat: add comprehensive credential management system for S3 Gateway#248szbr9486 merged 1 commit intoCurvineIO:mainfrom
szbr9486 merged 1 commit intoCurvineIO:mainfrom
Conversation
d84f23e to
e739864
Compare
ce15f11 to
29f420d
Compare
szbr9486
reviewed
Sep 10, 2025
szbr9486
approved these changes
Sep 11, 2025
szbr9486
pushed a commit
that referenced
this pull request
Sep 11, 2025
Coderlxl
pushed a commit
to Coderlxl/curvine
that referenced
this pull request
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a complete credential management system for the Curvine S3 Gateway, enabling secure storage and management of AWS Access Key/Secret Key pairs. The system supports both single-instance and multi-instance deployments with automatic synchronization capabilities.
Key Features
Dual Storage Modes
default: ~/.curvine/credentials.jsonl)default: /system/auth/credentials.jsonl)Security & Performance
SecretKeytype with automatic zeroizationManagement Operations
Technical Implementation
Architecture
AccessKeyStoreEnumprovides zero-cost abstraction over storage implementationsCacheStatestructure shared between local and distributed storesAccesskeyStoreandCredentialStoretraits for consistent APICacheRefreshTaskfor automatic credential synchronizationKey Components
LocalAccessKeyStore: Single-instance local file system storageCurvineAccessKeyStore: Multi-instance distributed storage with background refreshAccessKeyStoreEnum: Static dispatch wrapper for unified APICredentialEntry: Secure credential data structure with validationUsage
CLI Integration
The credential management is fully integrated into the gateway shell script:
Configuration
Enable distributed authentication in cluster configuration:
For local mode, simply set
enable_distributed_auth = falseor omit the section.