Merged
Conversation
bigbigxu
approved these changes
Sep 8, 2025
4f2e8cb to
a315087
Compare
lzjqsdd
reviewed
Sep 8, 2025
curvine-ufs/src/s3/s3_filesystem.rs
Outdated
|
|
||
| async fn rename(&self, _src: &Path, _dst: &Path) -> FsResult<bool> { | ||
| err_ufs!("Not supported") | ||
| if _src.is_root() || _dst.is_root() { |
Member
There was a problem hiding this comment.
_src，_dst no longer need _ prefix if parameter is used
Signed-off-by: swj <1186093704@qq.com>
szbr9486
pushed a commit
that referenced
this pull request
Sep 11, 2025
Signed-off-by: swj <1186093704@qq.com>
Coderlxl
pushed a commit
to Coderlxl/curvine
that referenced
this pull request
Dec 25, 2025
Signed-off-by: swj <1186093704@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.