Conversation
# Conflicts: # curvine-server/src/master/master_handler.rs # curvine-server/src/master/master_server.rs # curvine-server/src/worker/handler/worker_handler.rs # curvine-server/src/worker/load/worker_load_handler.rs # curvine-server/src/worker/mod.rs # curvine-server/src/worker/worker_server.rs # curvine-server/tests/master_fs_test.rs
szbr9486
reviewed
Aug 29, 2025
curvine-common/proto/job.proto
Outdated
| import "common.proto"; | ||
|
|
||
| // job and task status enumeration | ||
| enum WorkStateProto { |
Contributor
There was a problem hiding this comment.
WorkState->JobState maybe better？
Contributor
Author
There was a problem hiding this comment.
Both job and task have state, so a compromise name is used.
curvine-common/proto/job.proto
Outdated
|
|
||
| // job and task status enumeration | ||
| enum WorkStateProto { | ||
| WORK_STATE_PROTO_PENDING = 0; |
Contributor
There was a problem hiding this comment.
State enum number start with 1 maybe better? Zero means abnormal state.
curvine-common/proto/job.proto
Outdated
| // job and task status enumeration | ||
| enum WorkStateProto { | ||
| WORK_STATE_PROTO_PENDING = 0; | ||
| WORK_STATE_PROTO_LOADING = 1; |
curvine-common/src/conf/job_conf.rs
Outdated
| job_cleanup_ttl: Default::default(), | ||
| job_cleanup_ttl_str: "10m".to_string(), | ||
|
|
||
| job_max_files: 100000, |
Contributor
There was a problem hiding this comment.
100000 define as a constant variable
curvine-common/src/conf/job_conf.rs
Outdated
| task_report_interval: Default::default(), | ||
| task_report_interval_str: "5s".to_string(), | ||
|
|
||
| worker_max_concurrent_tasks: 1000, |
| use crate::worker::task::TaskContext; | ||
|
|
||
| #[derive(Clone)] | ||
| pub struct TaskStore { |
Contributor
There was a problem hiding this comment.
What is the difference between job and task？
Contributor
Author
There was a problem hiding this comment.
The job will be split into multiple tasks and distributed to different workers for execution.
szbr9486
approved these changes
Aug 29, 2025
szbr9486
pushed a commit
that referenced
this pull request
Sep 11, 2025
Coderlxl
pushed a commit
to Coderlxl/curvine
that referenced
this pull request
Dec 25, 2025
…O#228) * fix: fix the bug that FsWriter pos, pos_mut return values are incorrect * fix: ufs path parsing bug fix * feat: data loading module code optimization (CurvineIO#227) * style: improve code readability while maintaining functionality"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.