fix: illegal option hostname on macos#179
Merged
szbr9486 merged 1 commit intoCurvineIO:mainfrom Aug 12, 2025
Merged
Conversation
Signed-off-by: swj <1186093704@qq.com>
szbr9486
reviewed
Aug 12, 2025
| # Get the IP address from ifconfig, taking the last network interface address | ||
| LOCAL_HOSTNAME="localhost" | ||
| LOCAL_IP=$(hostname -I | awk '{print $NF}') | ||
| LOCAL_IP=$(ifconfig | grep "inet " | awk '{print $2}' | grep -v 127.0.0.1 | tail -n 1) |
Contributor
There was a problem hiding this comment.
Is it more concise replaced as
hostname -i | awk 'print $NF'
Contributor
Author
There was a problem hiding this comment.
on macos, hostname doen't have the -i option.
szbr9486
approved these changes
Aug 12, 2025
Member
|
This may disrupt the checks of other systems or distributions. For example, Ubuntu no longer provides the ifconfig tool by default.AThis fix can be made according to different systems. |
lzjqsdd
reviewed
Aug 12, 2025
| LOCAL_IP=$(hostname -I | awk '{print $NF}') | ||
| LOCAL_IP=$(ifconfig | grep "inet " | awk '{print $2}' | grep -v 127.0.0.1 | tail -n 1) | ||
|
|
||
| # master bound host name |
Member
There was a problem hiding this comment.
it would be better to check the system version to select the detection method according to different systems.
Contributor
Author
There was a problem hiding this comment.
get, I will improve this in next pr.
Coderlxl
pushed a commit
to Coderlxl/curvine
that referenced
this pull request
Dec 25, 2025
Signed-off-by: swj <1186093704@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.