Conversation
szbr9486
reviewed
Aug 11, 2025
| return; | ||
| } catch (UnsatisfiedLinkError e) { | ||
| // pass | ||
| LOGGER.warn("xxx {} {}", libraryName, e); |
Contributor
There was a problem hiding this comment.
why delete this warning log info
Contributor
Author
There was a problem hiding this comment.
This is the debug log, which was submitted by mistake before.
Contributor
There was a problem hiding this comment.
It is true that some error logs need to be printed here
curvine-libsdk/src/lib.rs
Outdated
|
|
||
| pub mod java; | ||
| pub mod python; | ||
| // pub mod python; |
szbr9486
reviewed
Aug 11, 2025
| return; | ||
| } catch (UnsatisfiedLinkError e) { | ||
| // pass | ||
| LOGGER.warn("xxx {} {}", libraryName, e); |
Contributor
There was a problem hiding this comment.
It is true that some error logs need to be printed here
| LOGGER.info("Loaded {} by System.loadLibrary", filename); | ||
| System.load(filename); | ||
| } catch (Throwable e) { | ||
| LOGGER.warn("xxx {} {}", libraryName, e); |
szbr9486
approved these changes
Aug 11, 2025
Coderlxl
pushed a commit
to Coderlxl/curvine
that referenced
this pull request
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.