fix: Add Master readiness check in mini-cluster to prevent startup race conditions in test environment#162
Merged
szbr9486 merged 1 commit intoCurvineIO:mainfrom Aug 11, 2025
Merged
Conversation
szbr9486
reviewed
Aug 11, 2025
|
|
||
| while LocalTime::mills() <= wait_time { | ||
| retry_count += 1; | ||
| let info = fs.get_master_info().await?; |
Contributor
There was a problem hiding this comment.
change info to master_info
…ce conditions in test environment (CurvineIO#161)
szbr9486
approved these changes
Aug 11, 2025
Coderlxl
pushed a commit
to Coderlxl/curvine
that referenced
this pull request
Dec 25, 2025
…ce conditions in test environment (CurvineIO#161) (CurvineIO#162) Co-authored-by: jianglong <771989*Jl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition in the mini-cluster test environment where Workers would attempt to connect to the Master before its RPC service was fully initialized, causing "Failed to connect" warnings and test instability.
Changes:
wait_master_ready()function to ensure Master is fully operational before starting WorkersImpact: