Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an inconsistency between clippy and build modes by making the pre-commit script accept a configurable profile parameter instead of always using release mode.
- Adds parameter processing to the pre-commit script to accept a build profile
- Updates the Makefile to pass the MODE variable to the pre-commit script
- Defaults to "release" profile when no parameter is provided or when "-r" is passed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| build/pre-commit.sh | Adds profile parameter handling with default to "release" |
| Makefile | Updates format target to pass MODE variable to pre-commit script |
| PROFILE="release" | ||
| fi | ||
|
|
||
| cargo clippy --release --fix --all-targets --allow-dirty --allow-staged --allow-no-vcs -- --deny warnings --allow clippy::uninlined-format-args |
There was a problem hiding this comment.
The cargo clippy command still uses hardcoded --release flag instead of using the $PROFILE variable that was introduced. This doesn't fix the inconsistency issue described in the PR title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.