Add ability to have deterministic bundle builds on all platforms#996
Merged
carneyweb merged 21 commits intodevelopmentfrom Apr 4, 2024
Merged
Add ability to have deterministic bundle builds on all platforms#996carneyweb merged 21 commits intodevelopmentfrom
carneyweb merged 21 commits intodevelopmentfrom
Conversation
1882747 to
1570059
Compare
Contributor
|
No warnings, LGTM! |
1 similar comment
Contributor
|
No warnings, LGTM! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #996 +/- ##
===============================================
- Coverage 88.86% 88.60% -0.26%
===============================================
Files 222 221 -1
Lines 12533 12545 +12
===============================================
- Hits 11137 11116 -21
- Misses 1396 1429 +33
|
jeffdiclemente
requested changes
Feb 15, 2024
Member
jeffdiclemente
left a comment
There was a problem hiding this comment.
there needs to be tests to make sure the timestamps are what is expected.
also, what about file ordering within the zip? I would think that if clients add more files to their meta data ZIP files, this will also be a problem for reproducible builds. See https://reproducible-builds.org/docs/archives/
Contributor
|
No warnings, LGTM! |
1 similar comment
Contributor
|
No warnings, LGTM! |
Contributor
|
No warnings, LGTM! |
2 similar comments
Contributor
|
No warnings, LGTM! |
Contributor
|
No warnings, LGTM! |
…nistic builds on win64
22b8a7e to
b242be6
Compare
jeffdiclemente
requested changes
Mar 27, 2024
Contributor
|
No warnings, LGTM! |
Contributor
|
No warnings, LGTM! |
Contributor
|
No warnings, LGTM! |
Contributor
|
No warnings, LGTM! |
Contributor
|
No warnings, LGTM! |
Contributor
|
No warnings, LGTM! |
Contributor
|
No warnings, LGTM! |
Contributor
|
No warnings, LGTM! |
jeffdiclemente
approved these changes
Mar 29, 2024
RobertLauferElektrobit
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Jul 24, 2025
…MicroServices#996) * Added CMake option and associated miniz changes to facilitate deterministic builds on win64 * Added support for maci64 * Some more updates * Fixed up stuff for maci * Updated comments and other things * Added support for deterministic locales when building * Updated LC_* variables to simply use LC_ALL instead * Add in test to validate deterministic zip file creation. * add deterministic zip file tests to build configurations for github. * fix syntax issue in yml file * restore old version of some code. * Try this. * add support for deterministic bundle linking on maci64 * got the CMAKE_CXX_LINK_LAUNCHER to work for linking deterministic on maci64. * deterministic testing * Fixed issues with .bat test for deterministic bundles on win64 * updated basic_test.sh with new format and removed old rc_tests.cmake * Added some comments describing the changes. * respond to code review requests. * fixed a typo. * respond to code review feedback. --------- Co-authored-by: alchrist <alchrist@mathworks.com> Co-authored-by: Michael Carney <mike@carneyweb.com>
jeffdiclemente
pushed a commit
that referenced
this pull request
Jul 25, 2025
… (#1148) * Added CMake option and associated miniz changes to facilitate deterministic builds on win64 * Added support for maci64 * Some more updates * Fixed up stuff for maci * Updated comments and other things * Added support for deterministic locales when building * Updated LC_* variables to simply use LC_ALL instead * Add in test to validate deterministic zip file creation. * add deterministic zip file tests to build configurations for github. * fix syntax issue in yml file * restore old version of some code. * Try this. * add support for deterministic bundle linking on maci64 * got the CMAKE_CXX_LINK_LAUNCHER to work for linking deterministic on maci64. * deterministic testing * Fixed issues with .bat test for deterministic bundles on win64 * updated basic_test.sh with new format and removed old rc_tests.cmake * Added some comments describing the changes. * respond to code review requests. * fixed a typo. * respond to code review feedback. --------- Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com> Co-authored-by: alchrist <alchrist@mathworks.com> Co-authored-by: Michael Carney <mike@carneyweb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.